-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recipe refinement (det, iseg, r-det, sseg, vpm, zsl) #3712
Recipe refinement (det, iseg, r-det, sseg, vpm, zsl) #3712
Conversation
064232a
to
22d648b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3712 +/- ##
===========================================
- Coverage 80.55% 80.54% -0.01%
===========================================
Files 254 254
Lines 25611 25610 -1
===========================================
- Hits 20631 20628 -3
- Misses 4980 4982 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This reverts commit 2ea6ee8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, this is a pretty big change, and one that was discussed a lot during the config design discussions for OTX 2.0. If a change is needed, it needs more discussion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thank you for the contribution!
Summary
This PR includes:
rotated detection-> no benchmark testHow to test
Checklist
License
Feel free to contact the maintainers if that's a concern.