Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump datumaro to 1.7.0 #3669

Merged
merged 4 commits into from
Jun 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .ci/docker/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

```bash
training_extensions/.ci/docker$ ./build.sh --help
USAGE: .ci/docker/build.sh <tag> [Options]
USAGE: ./build.sh <tag> [Options]
Positional args
<tag> Tag name to be tagged to newly built image
Options
Expand All @@ -18,7 +18,7 @@
Below example builds an image using actions-runner v2.317.0 based on NVIDIA cuda image and tag it as `2.317.0`.

```bash
training_extensions$ .ci/build.sh 2.317.0 -u https://github.com/actions/runner/releases/download/v2.305.0/actions-runner-linux-x64-2.305.0.tar.gz
training_extensions/.ci/docker$ ./build.sh 2.317.0 -u https://github.com/actions/runner/releases/download/v2.305.0/actions-runner-linux-x64-2.305.0.tar.gz
```

> **_Note_**: While building an image, script will use your system's environment variables `http_proxy`, `https_proxy`, and `no_proxy`. If you need to use proxy to access external entity, please check those settings before using this script.
Expand Down Expand Up @@ -55,7 +55,7 @@
Below example starts a runner named as `<container-prefix>-0` with GPU ID 0 (GPU ID will be attached to both container and runner name)

```bash
training_extensions$ .ci/start-runner.sh <container-prefix> <github-token> -g 0
training_extensions$ .ci/docker/start-runner.sh <container-prefix> <github-token> -g 0
```

If there exist the container named as same, it will be stopped before starting a new container.
Expand Down Expand Up @@ -86,14 +86,14 @@
Below example stops a runner named as `otx-ci-container`

```bash
training_extensions$ .ci/stop-runner.sh otx-ci-container <github-token>
training_extensions$ .ci/docker/stop-runner.sh otx-ci-container <github-token>
```

> **_Note_**: If there is an action in progress on the actions-runner which you want to stop, this script will be resulted with an error. To perform force stopping the runner, you can stop the docker container using `docker stop` command on the host machine.

1. Monitor the running runner
```bash
training_extensions$ .ci/check-runner.sh --help
training_extensions$ .ci/docker/check-runner.sh --help
USAGE: .ci/check-runner.sh <container-name> [Options]
Options
-r|--runner Check runner's log instead of Job one
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ classifiers = [
"Programming Language :: Python :: 3.11",
]
dependencies = [
"datumaro==1.6.1",
"datumaro==1.7.0",
"omegaconf==2.3.0",
"rich==13.7.1",
"jsonargparse==4.30.0",
Expand Down
7 changes: 3 additions & 4 deletions src/otx/core/data/dataset/segmentation.py
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,9 @@ def __init__(
@property
def has_polygons(self) -> bool:
"""Check if the dataset has polygons in annotations."""
for subset in self.dm_subset.subsets().values():
annot_types = set(subset.get_annotated_type())
if annot_types & {"polygon", "ellipse"}:
return True
ann_types = {str(ann_type).split(".")[-1] for ann_type in self.dm_subset.ann_types()}
if ann_types & {"polygon", "ellipse"}:
return True
return False

def _get_item_impl(self, index: int) -> SegDataEntity | None:
Expand Down
Loading