-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a flag to enable OV inference on dGPU #3503
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovrasov
requested review from
samet-akcay,
harimkang,
vinnamkim,
jaegukhyun,
eugene123tw,
kprokofi,
chuneuny-emily,
sungchul2,
GalyaZalesskaya,
negvet,
goodsong81,
yunchu,
wonjuleee and
eunwoosh
as code owners
May 15, 2024 13:25
github-actions
bot
added
TEST
Any changes in tests
DOC
Improvements or additions to documentation
OTX 2.0
labels
May 15, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3503 +/- ##
===========================================
+ Coverage 83.09% 83.10% +0.01%
===========================================
Files 254 254
Lines 25235 25236 +1
===========================================
+ Hits 20969 20973 +4
+ Misses 4266 4263 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sovrasov
changed the title
Use dGPU for OV inference, if possible
Add a flag to enable OV inference on dGPU
May 15, 2024
sovrasov
force-pushed
the
vs/ov_propagate_device
branch
2 times, most recently
from
May 15, 2024 16:28
9a5124a
to
cf52ccb
Compare
harimkang
approved these changes
May 17, 2024
eunwoosh
approved these changes
May 17, 2024
eunwoosh
pushed a commit
to eunwoosh/training_extensions
that referenced
this pull request
Jun 5, 2024
* dGPU inference for OV models * Extract reading of hparams in OVModel * Fix usage of get_user_config * Fix ruff * Add for cpu flag to ov model * Fix missing ov core * Fix plugin coniguration * Add one more unit test for OVModel * Fix imports * Revert inf exp changes --------- Co-authored-by: kprokofi <kirill.prokofiev@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Also, OV model outputs are now consistent with --engine.device
Performance results are contradictive, apparently we need a specially tuned inference code to get a gain from dGPU.
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.