Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NMS iou threshold configurable parameter #3287

Merged
merged 13 commits into from
Apr 11, 2024

Conversation

jaegukhyun
Copy link
Contributor

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests labels Apr 8, 2024
@github-actions github-actions bot added the DOC Improvements or additions to documentation label Apr 8, 2024
@jaegukhyun jaegukhyun changed the title Iou threshold Add iou threshold configurable parameter Apr 8, 2024
@jaegukhyun jaegukhyun changed the title Add iou threshold configurable parameter Add NMS iou threshold configurable parameter Apr 8, 2024
@jaegukhyun jaegukhyun marked this pull request as ready for review April 8, 2024 13:59
@jaegukhyun jaegukhyun requested a review from a team as a code owner April 8, 2024 13:59
@sovrasov
Copy link
Contributor

sovrasov commented Apr 8, 2024

Are detectors so sensitive to IoU in NMS? We shouldn't apply any default value tricks, since it all is visible in the UI.
My initial thought was to bind 0.5 default value for all detectors and tilers, conduct a couple experiments, and call it a day. Unfortunately, that's a sacrifice we're making because of the imperfect Geti configuration system, which doesn't support per model tuning for default params.

If that's not possible (the detectors are too sensitive, we could think of changing the tiling threshold only)

@eugene123tw
Copy link
Contributor

Are detectors so sensitive to IoU in NMS? We shouldn't apply any default value tricks, since it all is visible in the UI. My initial thought was to bind 0.5 default value for all detectors and tilers, conduct a couple experiments, and call it a day. Unfortunately, that's a sacrifice we're making because of the imperfect Geti configuration system, which doesn't support per model tuning for default params.

If that's not possible (the detectors are too sensitive, we could think of changing the tiling threshold only)

@jaegukhyun Based on the experiment: https://intel-my.sharepoint.com/:x:/p/eugene_liu/EWr2Xk17brBDgqZO62qlgSIBNNugJIalJZTWQJYqmaNiVg?e=SgQqpe

Let's change the default NMS IoU threshold to 0.5, what do you think?

Copy link
Contributor

@eugene123tw eugene123tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some minor comments

eugene123tw
eugene123tw previously approved these changes Apr 11, 2024
Copy link
Contributor

@eugene123tw eugene123tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jaeguk!

sovrasov
sovrasov previously approved these changes Apr 11, 2024
@jaegukhyun jaegukhyun merged commit 6065a7c into openvinotoolkit:releases/1.6.0 Apr 11, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation DOC Improvements or additions to documentation TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants