Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge develop to Intel dGPU branch #2927

Merged
merged 7 commits into from
Feb 20, 2024
Merged

Conversation

kprokofi
Copy link
Collaborator

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@kprokofi kprokofi requested a review from a team as a code owner February 18, 2024 21:30
@github-actions github-actions bot added DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM API Any changes in OTX API CLI Any changes in OTE CLI ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests BUILD DOC Improvements or additions to documentation labels Feb 18, 2024
@kprokofi kprokofi force-pushed the kp/merge_develop_idev branch from 7522d1b to 786e4a5 Compare February 18, 2024 22:22
Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: 92 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (develop-idev@dee113c). Click here to learn what that means.

Files Patch % Lines
.../otx/algorithms/visual_prompting/tasks/openvino.py 81.81% 36 Missing ⚠️
...els/visual_prompters/zero_shot_segment_anything.py 82.66% 26 Missing ⚠️
...on/adapters/mmdet/models/detectors/mean_teacher.py 36.36% 14 Missing ⚠️
src/otx/cli/utils/hpo.py 68.18% 7 Missing ⚠️
...otx/algorithms/visual_prompting/tasks/inference.py 91.89% 6 Missing ⚠️
...sification/adapters/mmcls/datasets/otx_datasets.py 0.00% 1 Missing ⚠️
...rch_lightning/datasets/pipelines/sam_transforms.py 85.71% 1 Missing ⚠️
src/otx/cli/tools/train.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             develop-idev    #2927   +/-   ##
===============================================
  Coverage                ?   79.94%           
===============================================
  Files                   ?      533           
  Lines                   ?    40307           
  Branches                ?        0           
===============================================
  Hits                    ?    32223           
  Misses                  ?     8084           
  Partials                ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@eunwoosh eunwoosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! I leave one question. Please take a look.

src/otx/algorithms/classification/adapters/mmcls/task.py Outdated Show resolved Hide resolved
@sovrasov
Copy link
Contributor

@kprokofi let's keep only merge-related changes here

@sovrasov sovrasov merged commit 54751ca into develop-idev Feb 20, 2024
15 checks passed
@sovrasov sovrasov deleted the kp/merge_develop_idev branch February 20, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation API Any changes in OTX API BUILD CLI Any changes in OTE CLI DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM DOC Improvements or additions to documentation TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants