Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mergeback 1.5.0rc1 #2562

Merged
merged 8 commits into from
Oct 18, 2023
Merged

Mergeback 1.5.0rc1 #2562

merged 8 commits into from
Oct 18, 2023

Conversation

yunchu
Copy link
Contributor

@yunchu yunchu commented Oct 18, 2023

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

eunwoosh and others added 8 commits October 18, 2023 10:54
@eunwoosh @yunchu
Delete mem cache handler after training is done (#2535)
640d9be 
release mem cache handler after training is done
@eunwoosh @yunchu
Fix bug that auto batch size doesn't consider distributed training (#…
5120111 
…2533)

* consider distributed training while searching batch size

* update unit test

* reveret gpu memory upper bound

* fix typo

* change allocated to reserved

* add unit test for distributed training

* align with pre-commit
@sungmanc @eunwoosh @yunchu
Apply fix progress hook to release 1.5.0 (#2539)
a6fc14c 
* Fix hook's ordering issue. AdaptiveRepeatHook changes the runner.max_iters before the ProgressHook

* Change the expression

* Fix typo

* Fix multi-label, h-label issue

* Fix auto_bs issue

* Apply suggestions from code review

Co-authored-by: Eunwoo Shin <eunwoo.shin@intel.com>

* Reflecting reviews

* Refactor the name of get_data_cfg

* Revert adaptive hook sampler init

* Refactor the function name: get_data_cfg -> get_subset_data_cfg

* Fix unit test errors

* Remove adding AdaptiveRepeatDataHook for autobs

* Remove unused import

* Fix detection and segmentation case in Geti scenario

---------

Co-authored-by: Eunwoo Shin <eunwoo.shin@intel.com>
@jaegukhyun @yunchu
Re-introduce adaptive training (#2543)
0da58f0 
* Re-introduce adaptive patience for training

* Revert unit tests
@goodsong81 @yunchu
Fix auto input size mismatch in eval & export (#2530)
fe4762d 
* Fix auto input size mismatch in eval & export

* Re-enable E2E tests for Issue#2518

* Add input size check in export testing

* Format float numbers in log

* Fix NNCF export shape mismatch

* Fix saliency map issue

* Disable auto input size if tiling enabled

---------

Signed-off-by: Songki Choi <songki.choi@intel.com>
@yunchu
Update ref. fq number for anomaly e2e2 (#2547)
f928417
@yunchu
Skip e2e det tests by issue2548 (#2550)
2d9b60d
@yunchu
Add skip to chained TC for issue #2548 (#2552)
87a7735
@yunchu yunchu requested a review from a team as a code owner October 18, 2023 02:00
@github-actions github-actions bot added ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests labels Oct 18, 2023
goodsong81
goodsong81 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My part looks OK. Thanks!

@yunchu
Copy link
Contributor Author

yunchu commented Oct 18, 2023

@eunwoosh @sungmanc @jaegukhyun can you guys review your part on here?

eunwoosh
eunwoosh approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@eunwoosh eunwoosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work. My part looks good to me :)

@codecov
Copy link

codecov bot commented Oct 18, 2023 •
edited
Loading

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (b3f5fc4) 81.37% compared to head (87a7735) 81.39%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2562      +/-   ##
===========================================
+ Coverage    81.37%   81.39%   +0.02%     
===========================================
  Files          513      513              
  Lines        37851    37911      +60     
===========================================
+ Hits         30800    30859      +59     
- Misses        7051     7052       +1
Flag Coverage Δ
py310 81.39% <94.39%> (+0.02%) ⬆️
py38 81.36% <94.39%> (+0.01%) ⬆️
py39 81.37% <94.39%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rithms/classification/adapters/mmcls/configurer.py 83.96% <100.00%> (ø)
...orithms/classification/adapters/mmcls/nncf/task.py 84.90% <100.00%> (+0.59%) ⬆️
...x/algorithms/classification/adapters/mmcls/task.py 88.92% <100.00%> (+0.03%) ⬆️
.../otx/algorithms/common/adapters/mmcv/configurer.py 93.91% <100.00%> (+0.09%) ⬆️
...mmon/adapters/mmcv/hooks/adaptive_training_hook.py 97.26% <100.00%> (+0.33%) ⬆️
...thms/common/adapters/torch/utils/bs_search_algo.py 89.28% <100.00%> (+1.48%) ⬆️
src/otx/algorithms/common/utils/utils.py 73.95% <100.00%> (+0.27%) ⬆️
.../algorithms/detection/adapters/mmdet/configurer.py 96.52% <100.00%> (ø)
...x/algorithms/detection/adapters/mmdet/nncf/task.py 88.13% <100.00%> (+0.20%) ⬆️
...rc/otx/algorithms/detection/adapters/mmdet/task.py 85.50% <100.00%> (+0.04%) ⬆️
... and 8 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yunchu yunchu merged commit 23296d5 into develop Oct 18, 2023
15 checks passed
@yunchu yunchu deleted the infra/mergeback-1.5.0rc1 branch October 18, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaegukhyun jaegukhyun jaegukhyun approved these changes

@eunwoosh eunwoosh eunwoosh approved these changes

@sungmanc sungmanc sungmanc approved these changes

@goodsong81 goodsong81 goodsong81 approved these changes

Assignees
No one assigned
Labels
ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yunchu @goodsong81 @sungmanc @eunwoosh @jaegukhyun