Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set "Auto" as default input size mode #2515

Merged
merged 9 commits into from
Sep 25, 2023
Merged

Set "Auto" as default input size mode #2515

merged 9 commits into from
Sep 25, 2023

Conversation

goodsong81
Copy link
Contributor

@goodsong81 goodsong81 commented Sep 22, 2023 •
edited
Loading

Summary

  • Refine auto input size adaptation
  • Set "Auto" as default mode
  • Fix tests
  • Update documentation

How to test

  • Integration & e2e tests

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@goodsong81
Refine input size adaptation
43902cf 
Signed-off-by: Songki Choi <songki.choi@intel.com>
@goodsong81
Enable auto input size to integration tests
b730c87 
Signed-off-by: Songki Choi <songki.choi@intel.com>
@goodsong81
Set 'Auto' as default mode of input size config
0ae07c5 
Signed-off-by: Songki Choi <songki.choi@intel.com>
@goodsong81
Fix rotated detection config
ccade8f 
Signed-off-by: Songki Choi <songki.choi@intel.com>
@goodsong81
Update README.md
87192e2 
Signed-off-by: Songki Choi <songki.choi@intel.com>
@goodsong81 goodsong81 added the ENHANCE Enhancement of existing features label Sep 22, 2023
@github-actions github-actions bot added ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests DOC Improvements or additions to documentation labels Sep 22, 2023
@goodsong81
Update CHANGELOG.md
bbad786 
Signed-off-by: Songki Choi <songki.choi@intel.com>
@goodsong81
Fix pre-commit
9571e2f 
Signed-off-by: Songki Choi <songki.choi@intel.com>
@goodsong81
Fix unit tests
dceb74b 
Signed-off-by: Songki Choi <songki.choi@intel.com>
@goodsong81 goodsong81 marked this pull request as ready for review September 25, 2023 01:36
@goodsong81 goodsong81 requested a review from a team as a code owner September 25, 2023 01:36
sungmanc
sungmanc previously approved these changes Sep 25, 2023
View reviewed changes
eunwoosh
eunwoosh reviewed Sep 25, 2023
View reviewed changes
Copy link
Contributor

@eunwoosh eunwoosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! I left some comments. Please take a look.

README.md Outdated Show resolved Hide resolved
src/otx/algorithms/detection/configs/rotated_detection/configuration.yaml Outdated Show resolved Hide resolved
@goodsong81
Address review comments
62672e5 
Signed-off-by: Songki Choi <songki.choi@intel.com>
@goodsong81 goodsong81 requested a review from sungmanc September 25, 2023 02:48
@goodsong81 goodsong81 merged commit 0078967 into openvinotoolkit:develop Sep 25, 2023
13 checks passed
@goodsong81 goodsong81 deleted the refine/auto-input-size branch September 25, 2023 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eunwoosh eunwoosh eunwoosh approved these changes

@sungmanc sungmanc sungmanc approved these changes

Assignees
No one assigned
Labels
ALGO Any changes in OTX Algo Tasks implementation DOC Improvements or additions to documentation ENHANCE Enhancement of existing features TEST Any changes in tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goodsong81 @sungmanc @eunwoosh