Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mergeback 1.4.2rc2 #2464

Merged
merged 9 commits into from
Sep 4, 2023
Merged

Mergeback 1.4.2rc2 #2464

merged 9 commits into from
Sep 4, 2023

Conversation

yunchu
Copy link
Contributor

@yunchu yunchu commented Aug 30, 2023 •
edited
Loading

Summary

This PR contains updates on the releases/1.4.0 after 1.4.1 release.
I've tried to do my best but it's not easy to me. so I need to get the author's help.
@GalyaZalesskaya , @sovrasov, and @ashwinvaidya17, please have a look these changes carefully and leave the comments.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

GalyaZalesskaya and others added 6 commits August 30, 2023 17:26
@GalyaZalesskaya @yunchu
Fix label list order for h-label classification (#2440)
441ba1b 
* Fix label list for h-label cls
* Fix unit tests
@yunchu
Modified fq numbers for lite HRNET (#2445)
e086505 
modified fq numbers for lite HRNET
@sovrasov @yunchu
Update PTQ ignored scope for hrnet 18 mod2 (#2449)
30e3cd2 
Update ptq ignored scope for hrnet 18  mod2
@ashwinvaidya17 @yunchu
Fix OpenVINO inference for legacy models (#2450)
2443f82 
* bug fix for legacy openvino models

* Add tests

* Specific exceptions

---------
@sovrasov @GalyaZalesskaya @yunchu
Prevent zero-sized saliency map in tiling if tile size is too big (#2452
c6bacc2 
)

* Prevent zero-sized saliency map in tiling if tile size is too big

* Prevent zero-sized saliency in tiling (PyTorch)

* Add unit tests for Tiler merge features methods

---------

Co-authored-by: Galina <galina.zalesskaya@intel.com>
@yunchu
Update pot fq reference number (#2456)
57fade0 
update pot fq reference number to 15
@github-actions github-actions bot added CLI Any changes in OTE CLI ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests labels Aug 30, 2023
ashwinvaidya17
ashwinvaidya17 previously approved these changes Aug 31, 2023
View reviewed changes
GalyaZalesskaya
GalyaZalesskaya reviewed Sep 1, 2023
View reviewed changes
Copy link
Contributor

@GalyaZalesskaya GalyaZalesskaya left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I'll look at unit tests

@codecov
Copy link

codecov bot commented Sep 1, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.06% ⚠️

Comparison is base (6c93b24) 80.05% compared to head (7cae0d2) 80.00%.
Report is 4 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2464      +/-   ##
===========================================
- Coverage    80.05%   80.00%   -0.06%     
===========================================
  Files          511      513       +2     
  Lines        37433    37600     +167     
===========================================
+ Hits         29968    30080     +112     
- Misses        7465     7520      +55
Flag Coverage Δ
py310 79.99% <100.00%> (-0.06%) ⬇️
py38 79.98% <100.00%> (-0.06%) ⬇️
py39 79.98% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../ocr_lite_hrnet_18_mod2/ptq_optimization_config.py 100.00% <ø> (ø)
src/otx/cli/utils/io.py 99.10% <ø> (ø)
src/otx/algorithms/anomaly/tasks/openvino.py 39.66% <100.00%> (+12.51%) ⬆️
...lgorithms/classification/adapters/openvino/task.py 85.84% <100.00%> (+2.95%) ⬆️
src/otx/algorithms/classification/task.py 87.14% <100.00%> (+2.10%) ⬆️
...c/otx/algorithms/classification/utils/cls_utils.py 98.76% <100.00%> (+0.32%) ⬆️
...rithms/detection/adapters/mmdet/datasets/tiling.py 90.03% <100.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yunchu yunchu marked this pull request as ready for review September 3, 2023 23:35
@yunchu yunchu requested a review from a team as a code owner September 3, 2023 23:35
@yunchu yunchu merged commit 75b5058 into develop Sep 4, 2023
@yunchu yunchu deleted the infra/mergeback-1.4.2rc2 branch September 4, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sovrasov sovrasov sovrasov left review comments

@goodsong81 goodsong81 goodsong81 approved these changes

@GalyaZalesskaya GalyaZalesskaya GalyaZalesskaya approved these changes

@ashwinvaidya17 ashwinvaidya17 ashwinvaidya17 left review comments

Assignees
No one assigned
Labels
ALGO Any changes in OTX Algo Tasks implementation CLI Any changes in OTE CLI TEST Any changes in tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yunchu @goodsong81 @sovrasov @ashwinvaidya17 @GalyaZalesskaya