-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new object detector, Lite-DINO #2457
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ALGO
Any changes in OTX Algo Tasks implementation
TEST
Any changes in tests
DOC
Improvements or additions to documentation
labels
Aug 29, 2023
goodsong81
previously approved these changes
Aug 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
docs/source/guide/explanation/algorithms/object_detection/object_detection.rst
Outdated
Show resolved
Hide resolved
eunwoosh
reviewed
Aug 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your effort. I have some questions. please take a look.
src/otx/algorithms/detection/configs/detection/resnet50_lite_dino/template_experimental.yaml
Outdated
Show resolved
Hide resolved
src/otx/algorithms/detection/adapters/mmdet/models/detectors/custom_lite_dino.py
Show resolved
Hide resolved
sungmanc
previously approved these changes
Aug 29, 2023
eunwoosh
approved these changes
Aug 31, 2023
goodsong81
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a new object detector Lite-DINO, https://arxiv.org/pdf/2303.07335.pdf
The difference between DINO comes from encoder structure.
Newly added module is for new encoder structure(encoder -> encoder layer -> new FFN method)
Unit tests will be added in another PR(with DINO's unit test)
How to test
Intg test
Checklist
License
Feel free to contact the maintainers if that's a concern.