Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new object detector, Lite-DINO #2457

Merged
merged 15 commits into from
Aug 31, 2023

Conversation

jaegukhyun
Copy link
Contributor

@jaegukhyun jaegukhyun commented Aug 29, 2023

Summary

Add a new object detector Lite-DINO, https://arxiv.org/pdf/2303.07335.pdf
The difference between DINO comes from encoder structure.
Newly added module is for new encoder structure(encoder -> encoder layer -> new FFN method)
Unit tests will be added in another PR(with DINO's unit test)

How to test

Intg test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests DOC Improvements or additions to documentation labels Aug 29, 2023
@jaegukhyun jaegukhyun changed the title Lite dino Add a new object detector, Lite-DINO Aug 29, 2023
@jaegukhyun jaegukhyun marked this pull request as ready for review August 29, 2023 08:12
@jaegukhyun jaegukhyun requested a review from a team as a code owner August 29, 2023 08:12
goodsong81
goodsong81 previously approved these changes Aug 29, 2023
Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@eunwoosh eunwoosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your effort. I have some questions. please take a look.

sungmanc
sungmanc previously approved these changes Aug 29, 2023
@jaegukhyun jaegukhyun dismissed stale reviews from sungmanc and goodsong81 via 841dc74 August 31, 2023 00:09
@jaegukhyun jaegukhyun merged commit 8045480 into openvinotoolkit:develop Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation DOC Improvements or additions to documentation TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants