Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: using auto adapt batch size with IterBasedRunner #2182

Merged
merged 6 commits into from
May 25, 2023
Merged

bugfix: using auto adapt batch size with IterBasedRunner #2182

merged 6 commits into from
May 25, 2023

Conversation

eunwoosh
Copy link
Contributor

@eunwoosh eunwoosh commented May 24, 2023 •
edited
Loading

Summary

Fix an issue #2180
There is no code to handle IterBasedRunner in auto adapt batch size code, so I added it.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@eunwoosh eunwoosh added the FIX defect fix label May 24, 2023
@eunwoosh eunwoosh added this to the 1.4.0 milestone May 24, 2023
@github-actions github-actions bot added ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests labels May 24, 2023
@github-actions github-actions bot added the DOC Improvements or additions to documentation label May 24, 2023
@eunwoosh eunwoosh marked this pull request as ready for review May 24, 2023 01:31
@eunwoosh eunwoosh requested a review from a team as a code owner May 24, 2023 01:31
@eunwoosh eunwoosh changed the title Es/make adapt bs run iter runner bugfix: using auto adapt batch size with IterBasedRunner May 24, 2023
jaegukhyun
jaegukhyun reviewed May 24, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
jaegukhyun
jaegukhyun approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@jaegukhyun jaegukhyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you for fixing

sungmanc
sungmanc approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@sungmanc sungmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sungmanc sungmanc merged commit 6d3a8aa into openvinotoolkit:develop May 25, 2023
@sungmanc sungmanc mentioned this pull request May 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaegukhyun jaegukhyun jaegukhyun approved these changes

@sungmanc sungmanc sungmanc approved these changes

Assignees
No one assigned
Labels
ALGO Any changes in OTX Algo Tasks implementation DOC Improvements or additions to documentation FIX defect fix TEST Any changes in tests
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@eunwoosh @sungmanc @jaegukhyun