Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc for fast data loading #2069

Merged
merged 5 commits into from
Apr 26, 2023
Merged

Add doc for fast data loading #2069

merged 5 commits into from
Apr 26, 2023

Conversation

cih9088
Copy link
Contributor

@cih9088 cih9088 commented Apr 25, 2023

Summary

Added doc for fast data loading

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@cih9088 cih9088 added the DOC Improvements or additions to documentation label Apr 25, 2023
@cih9088 cih9088 added this to the 1.3.0 milestone Apr 25, 2023
@cih9088 cih9088 requested a review from vinnamkim April 25, 2023 07:32
@cih9088 cih9088 requested a review from a team as a code owner April 25, 2023 07:32
@cih9088 cih9088 requested a review from wonjuleee April 25, 2023 07:38
sungmanc
sungmanc reviewed Apr 25, 2023
View reviewed changes
Copy link
Contributor

@sungmanc sungmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the cli_commands document? It missed the contents to introduce how to use ArrowFormat in OTX CLI.

@cih9088
Copy link
Contributor Author

cih9088 commented Apr 25, 2023

Could you also update the cli_commands document? It missed the contents to introduce how to use ArrowFormat in OTX CLI.

Added in 6fb391b

sungmanc
sungmanc previously approved these changes Apr 26, 2023
View reviewed changes
@sungmanc
Copy link
Contributor

sungmanc commented Apr 26, 2023 •
edited
Loading

@goodsong81 , How about changing the target develop --> release/1.2.1 ?
This PR includes the documents of 1.2.0's features

@goodsong81
Copy link
Contributor

@goodsong81 , How about changing the target develop --> release/1.2.1 ? This PR includes the documents of 1.2.0's features

I agree, for the completeness. Thanks for the suggestion.

@goodsong81
Copy link
Contributor

@cih9088 If you retarget this PR to 1.2.1, I would merge it right away. Thanks!

goodsong81
goodsong81 previously approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@goodsong81 goodsong81 changed the base branch from develop to releases/1.2.1 April 26, 2023 01:02
@goodsong81 goodsong81 dismissed stale reviews from sungmanc and themself April 26, 2023 01:02

The base branch was changed.

@cih9088 cih9088 force-pushed the docs/fast-data-loading branch from 6fb391b to d218335 Compare April 26, 2023 01:05
@cih9088 cih9088 requested review from goodsong81 and sungmanc April 26, 2023 01:05
@goodsong81 goodsong81 merged commit 6e2c710 into openvinotoolkit:releases/1.2.1 Apr 26, 2023
goodsong81 pushed a commit to goodsong81/training_extensions that referenced this pull request Apr 27, 2023
@cih9088 @goodsong81
Add doc for fast data loading (openvinotoolkit#2069)
ea7fb12 
* docs: add fast data loading

* docs: add augmix

* docs: use reference

* docs: make first character of words capital

* docs: add simple example in cli command
goodsong81 added a commit that referenced this pull request May 3, 2023
@goodsong81 @eunwoosh
@supersoob @cih9088 @eugene123tw @harimkang @jaegukhyun
Merge back 1.2.1 RC1 & RC2 (#2086)
a1f098d 
* Upgrade mmdeploy==0.14.0 from official PyPI (#2047)

* Bug fix: value of validation variable is changed after auto decrease batch size (#2053)

* Integrate new ignored loss in semantic segmentation (#2065)

* Remove unused modules in semantic segmentation (#2068)

* Add doc for fast data loading (#2069)

* Bug fix: set gpu_ids properly (#2071)

* Bug fix: Progress goes 100% and back 0 % repeatedly during auto decrease bs in Geti (#2074)

* Fix tiling 0 stride issue in parameter adapter (#2078)

* Update instance-segmentation tutorial documentation (#2082)

* Optimize YOLOX data pipeline and add unit test for get_subset of Datu… (#2075)

* Tiling Spatial Concatenation for OpenVINO IR (#2052)

* Add spatial concatenation to deployment demo (#2089)

---------

Signed-off-by: Songki Choi <songki.choi@intel.com>
Co-authored-by: Eunwoo Shin <eunwoo.shin@intel.com>
Co-authored-by: Soobee Lee <soobee.lee@intel.com>
Co-authored-by: Inhyuk Cho <andy.inhyuk.jo@intel.com>
Co-authored-by: Eugene Liu <eugene.liu@intel.com>
Co-authored-by: Harim Kang <harim.kang@intel.com>
Co-authored-by: Jaeguk Hyun <jaeguk.hyun@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sungmanc sungmanc sungmanc approved these changes

@goodsong81 goodsong81 goodsong81 approved these changes

@vinnamkim vinnamkim Awaiting requested review from vinnamkim

@wonjuleee wonjuleee Awaiting requested review from wonjuleee

Assignees
No one assigned
Labels
DOC Improvements or additions to documentation
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cih9088 @sungmanc @goodsong81