-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action task supports multi GPU training #2057
Action task supports multi GPU training #2057
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!. Could you add multi gpu test for action detection?
Thanks! it's not hard but my intention is adding as little as possible test to integration test to reduce test time. |
It make sense to me. Could you add multi-gpu test for action classification and action detection in e2e tests? |
I added it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but could you please fix one thing below?
Summary
This PR enables multi GPU training to action task.
Current multi GPU training needs to be refactored because code flow for multi GPU enablement in each tasks are all different.
I'll refactored it after this pr is merged and at that time I'll implement unit test for that.
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.