Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action task supports multi GPU training #2057

Merged
merged 8 commits into from
Apr 25, 2023

Conversation

eunwoosh
Copy link
Contributor

@eunwoosh eunwoosh commented Apr 24, 2023

Summary

This PR enables multi GPU training to action task.
Current multi GPU training needs to be refactored because code flow for multi GPU enablement in each tasks are all different.
I'll refactored it after this pr is merged and at that time I'll implement unit test for that.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@eunwoosh eunwoosh added this to the 1.3.0 milestone Apr 24, 2023
@eunwoosh eunwoosh requested a review from jaegukhyun April 24, 2023 06:02
@eunwoosh eunwoosh requested a review from a team as a code owner April 24, 2023 06:02
@github-actions github-actions bot added ALGO Any changes in OTX Algo Tasks implementation CLI Any changes in OTE CLI TEST Any changes in tests labels Apr 24, 2023
Copy link
Contributor

@jaegukhyun jaegukhyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!. Could you add multi gpu test for action detection?

@eunwoosh
Copy link
Contributor Author

LGTM!. Could you add multi gpu test for action detection?

Thanks! it's not hard but my intention is adding as little as possible test to integration test to reduce test time.
Is it necessary to add test in detection task also? If yes, then I'll add it too.

@jaegukhyun
Copy link
Contributor

LGTM!. Could you add multi gpu test for action detection?

Thanks! it's not hard but my intention is adding as little as possible test to integration test to reduce test time. Is it necessary to add test in detection task also? If yes, then I'll add it too.

It make sense to me. Could you add multi-gpu test for action classification and action detection in e2e tests?
I think at least e2e should check all TC

@github-actions github-actions bot added the DOC Improvements or additions to documentation label Apr 24, 2023
@eunwoosh
Copy link
Contributor Author

It make sense to me. Could you add multi-gpu test for action classification and action detection in e2e tests? I think at least e2e should check all TC

I added it.

jaegukhyun
jaegukhyun previously approved these changes Apr 24, 2023
Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could you please fix one thing below?

CHANGELOG.md Outdated Show resolved Hide resolved
@goodsong81 goodsong81 merged commit 3c0233d into openvinotoolkit:develop Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation CLI Any changes in OTE CLI DOC Improvements or additions to documentation TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants