Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix classification model download logic to resolve zip issue #1967

Merged
merged 5 commits into from
Apr 4, 2023
Merged

Fix classification model download logic to resolve zip issue #1967

merged 5 commits into from
Apr 4, 2023

Conversation

goodsong81
Copy link
Contributor

@goodsong81 goodsong81 commented Apr 4, 2023 •
edited
Loading

Summary

  • There is an error while trying to unzip *.pth.zip on read-only file system
  • pytorchcv downloading could avoid it by *.pth caching
  • Avoid downloading when given external pretrained models

How to test

  • Normal CI tests

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@goodsong81
Replace model download logic by pytorchcv to resolve zip issue
aea4e65 
Signed-off-by: Songki Choi <songki.choi@intel.com>
@goodsong81 goodsong81 requested a review from a team as a code owner April 4, 2023 01:12
@github-actions github-actions bot added the ALGO Any changes in OTX Algo Tasks implementation label Apr 4, 2023
@goodsong81 goodsong81 added HOTFIX FIX defect fix RELEASE and removed ALGO Any changes in OTX Algo Tasks implementation labels Apr 4, 2023
@github-actions github-actions bot added ALGO Any changes in OTX Algo Tasks implementation DOC Improvements or additions to documentation labels Apr 4, 2023
@goodsong81
Fix pre-commit
a512685 
Signed-off-by: Songki Choi <songki.choi@intel.com>
@goodsong81
Configure checkpoint before model
e0409c2
@goodsong81 goodsong81 changed the title Replace EfficentNetB0 model download logic by pytorchcv to resolve zip issue Fix classification model download logic to resolve zip issue Apr 4, 2023
@goodsong81
Add pytorchcv to cls/seg requirement
a0f77f2 
Signed-off-by: Songki Choi <songki.choi@intel.com>
@github-actions github-actions bot added the DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM label Apr 4, 2023
@goodsong81 goodsong81 merged commit f70c29b into openvinotoolkit:releases/1.1.2 Apr 4, 2023
goodsong81 added a commit to goodsong81/training_extensions that referenced this pull request Apr 4, 2023
@goodsong81
Fix classification model download logic to resolve zip issue (openvin…
712c15b 
…otoolkit#1967)

* Replace model download logic by pytorchcv to resolve zip issue

* Update change log

* Fix pre-commit

* Configure checkpoint before model

* Add pytorchcv to cls/seg requirement

---------
Signed-off-by: Songki Choi <songki.choi@intel.com>
goodsong81 added a commit that referenced this pull request Apr 5, 2023
@goodsong81 @negvet
Merge back bug fixes in release 1.1.2 (#1971)
6939daf 
* Fix exception -> warning for anomaly dump_feature option

* Remove `dataset.with_empty_annotations()` to keep original input structure (#1964)

* Fix OV batch inference (saliency map generation)  (#1965)

* Release 1.1.2 RC1

* Fix classification model download logic to resolve zip issue (#1967)

* Replace model download logic by pytorchcv to resolve zip issue

* Update change log

* Fix pre-commit

* Configure checkpoint before model

* Add pytorchcv to cls/seg requirement

* Hot fix for numpy attr for ResultMediaEntity

* Release 1.1.2

* Update exportable code demo commit

---------

Co-authored-by: Evgeny Tsykunov <evgeny.tsykunov@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sungmanc sungmanc sungmanc approved these changes

Assignees
No one assigned
Labels
ALGO Any changes in OTX Algo Tasks implementation DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM DOC Improvements or additions to documentation FIX defect fix HOTFIX RELEASE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goodsong81 @sungmanc