Move semantic-segmentation related codes to otx adapters #1911

supersoob · 2023-03-20T08:18:20Z

Summary

Moved modules which is registered in mmseg and used only in sseg in mpa folder to otx mmseg adapter. (except for stage files)

Move all mmseg dependant modules to otx/algo/seg/adapter/mmseg
Refactor codes to reduce inheritance/call depth
Fix pre-commit issues
Update test codes
Update docs
Check local test results

How to test

pytest tests/unit
pytest tests/e2e/cli/segmentation/test_segmentation.py

Checklist

I submit my changes into the develop branch
I have added description of my changes into CHANGELOG
I have updated the documentation accordingly
I have added tests to cover my changes
I have linked related issues

License

I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
I have updated the license header for each file (see an example below)

# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Updated daily workflow - remove if statement to allow running on any branch by manually

…_extensions into mpa-move

re bugfix

supersoob · 2023-03-20T09:28:29Z

Local e2e seg test

…_extensions into mpa-move

…raining_extensions into mpa-move

harimkang

Thanks, I've left a few comments.
It looks like we need to move our unit test files from MPA to OTX as well.

otx/algorithms/detection/adapters/mmdet/models/heads/custom_atss_head.py

otx/algorithms/segmentation/adapters/mmseg/datasets/pipelines/compose.py

otx/algorithms/segmentation/adapters/mmseg/models/backbones/litehrnet.py

otx/algorithms/segmentation/adapters/mmseg/models/segmentors/detcon.py

otx/algorithms/segmentation/adapters/mmseg/datasets/__init__.py

otx/algorithms/segmentation/adapters/__init__.py

otx/algorithms/segmentation/adapters/mmseg/models/segmentors/detcon.py

otx/mpa/seg/__init__.py

eunwoosh

Thanks for your work :)

codecov-commenter · 2023-03-21T02:45:37Z

Codecov Report

Patch coverage: 72.09% and no project coverage change.

Comparison is base (f7e4799) 80.65% compared to head (98fd89c) 80.66%.

Additional details and impacted files

@@               Coverage Diff               @@
##           releases/1.1.0    #1911   +/-   ##
===============================================
  Coverage           80.65%   80.66%           
===============================================
  Files                 490      484    -6     
  Lines               33406    33409    +3     
===============================================
+ Hits                26943    26948    +5     
+ Misses               6463     6461    -2

Impacted Files	Coverage Δ
...ms/segmentation/adapters/mmseg/datasets/dataset.py	`88.88% <ø> (ø)`
...tation/adapters/mmseg/models/losses/detcon_loss.py	`81.33% <ø> (ø)`
...entation/adapters/mmseg/models/necks/selfsl_mlp.py	`100.00% <ø> (ø)`
...mentation/adapters/mmseg/models/schedulers/base.py	`85.71% <ø> (ø)`
...rithms/segmentation/adapters/mmseg/nncf/builder.py	`92.75% <ø> (ø)`
...gorithms/segmentation/adapters/mmseg/nncf/hooks.py	`87.87% <ø> (ø)`
...rithms/segmentation/adapters/mmseg/nncf/patches.py	`100.00% <ø> (ø)`
.../mmseg/models/segmentors/mean_teacher_segmentor.py	`25.64% <13.63%> (ø)`
...ms/segmentation/adapters/mmseg/utils/data_utils.py	`89.20% <22.22%> (-4.64%)`	⬇️
.../segmentation/adapters/mmseg/models/heads/mixin.py	`39.75% <58.66%> (ø)`
... and 19 more

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

…raining_extensions into mpa-move

* Bump up version to 1.1.0rc1 * Updated daily workflow (#1905) - remove if statement to allow running on any branch by manually * [FIX] Wrong test temp directory path (#1902) * Fix wrong test temp directory * Update tests/unit/algorithms/action/adapters/mmaction/utils/test_action_config_utils.py * Update test_action_config_utils.py * Update PR template (#1914) * Update . location. * Fix OTX1.1 -> Geti1.4 integration issues (#1910) * Add dill to requirements/api.txt * Return None instead of raising NotImplementedError in IMedia2DEntity.path * Move utils HPO uses into HPO directory (#1912) move utils into hpo dir * [FIX] Add stability to explain detection (#1901) Add stability to explain detection * [Fix] e2e tests FQ references (#1918) Fix FQ references * Move mpa.deploy to otx.algorithms.common (#1903) * Move deploy modules to otx * test: fix mmdeploy api replacement error * Fix pre-commit issues * Update otx/mpa/det/exporter.py * Update otx/mpa/exporter_mixin.py * Update otx/mpa/seg/exporter.py * Update otx/mpa/cls/exporter.py * Update otx/algorithms/common/adapters/mmdeploy/utils/mmdeploy.py * Update otx/algorithms/common/adapters/mmdeploy/utils/operations_domain.py * Add mmcls.VisionTransformer backbone support (#1908) * Add mmcls transformer backbones * Fix VisionTransformeroutput check * Add changes * Disable recording forward hooks in inferrer * Remove unused import * Move semantic-segmentation related codes to otx adapters (#1911) * Added security.md Add the security related notification * Update security.md fix prettier issue * Add custom exception class for CLI (#1919) * Add custom exception class for CLI * Fixed TCs for config_manager * Correct License to Apache * Remove temp hot key values (#1916) * Refactor OTX classification phase 1: move modules from MPA to OTX (#1893) * Revert TrainType typo (#1928) * Fix Conflict * Fix conflict * Fix unit-tests * Fix cli tests * Fix cli tests * Fix type * Move all hooks in MPA into OTX common mmcv adapter (#1922) * Add explanation for XAI & minor doc fixes (#1923) * [CI] Updated daily workflow (#1904) Updated daily workflow - remove if statement to allow running on any branch by manually * [FIX] re-bugfix: ATSS head loss (#1907) re bugfix * Fix typos * Explanation of Explanation * Add images & typo fixes * Fixes from comments * Add accuracy for OD explanation * Tutorial update * Add accuracy for BCCD and WGISD * Fix * Move utils to OTX common & adapter (#1931) * [CI] Updated daily workflow (#1904) Updated daily workflow - remove if statement to allow running on any branch by manually * [FIX] re-bugfix: ATSS head loss (#1907) re bugfix * Added security.md Added the security related notification. * Update security.md fix prettier issue * Move utils * Fix typo * Move classification unit tests to OTX tests (#1932) * [CI] Updated daily workflow (#1904) Updated daily workflow - remove if statement to allow running on any branch by manually * [FIX] re-bugfix: ATSS head loss (#1907) re bugfix * Added security.md Added the security related notification. * Update security.md fix prettier issue * Move classification unit tests * Apply mocker in RandAugment TC * Move otx.mpa.modules.ov -> otx.core.ov (#1929) * First Refactoring * Refactor mpa.modules.ov -> otx.core.ov * Remove otx.mpa.modules.ov * Fix docs & unit test paths * Fix some import * Add TODO comments * Add github icon link in doc head (#1934) * Fix invalid temp_dir inside unit tests (#1937) * Move all model utils and dataloaders/samplers in mpa to otx adapter (#1930) * Move stages to each algorithms (#1938) * Move stages to each algorithms * Change docs for action recognition (#1940) * Change docs for action recognition * Fix typo * Update MoViNet related parts * Add MoViNet performance * Revert table include Complexity and Model size * Fix tox to run tests on non-editable install * Fix packaging errors including cython module build / import issues (#1936) * Avoid cychon compile on Windows * Fix packaging errors * Fix pre-commit * Remove use_develop option from tox tests * Fix pre-commit * Fix tox -e -> -re for clean build * Fix import error * Add missing __init__.py * Fix relative -> absolute import * Revert to editable package in tox tests * Release 1.1.0 (#1933) * Release OTX 1.1.0 * Update known issues in CHANGELOG.md * Fix PR / issue # to links * Fix pre-commit * Bump-up version to 1.2 * Fix pre-commit --------- Signed-off-by: Songki Choi <songki.choi@intel.com> Co-authored-by: Yunchu Lee <yunchu.lee@intel.com> Co-authored-by: Harim Kang <harim.kang@intel.com> Co-authored-by: Eunwoo Shin <eunwoo.shin@intel.com> Co-authored-by: Emily Chun <emily.chun@intel.com> Co-authored-by: emily.chun <chuneuny@ikvensx012> Co-authored-by: Sungman Cho <sungman.cho@intel.com> Co-authored-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com> Co-authored-by: Jaeguk Hyun <jaeguk.hyun@intel.com> Co-authored-by: Jihwan Eom <jihwan.eom@intel.com> Co-authored-by: Soobee Lee <soobee.lee@intel.com> Co-authored-by: Galina Zalesskaya <galina.zalesskaya@intel.com>

yunchu and others added 6 commits March 17, 2023 17:46

[CI] Updated daily workflow (openvinotoolkit#1904)

40559b0

Updated daily workflow - remove if statement to allow running on any branch by manually

modules to mmseg

42126b4

Merge branch 'develop' of https://github.com/openvinotoolkit/training…

22b38f9

…_extensions into mpa-move

revise init files

93e165d

fix precommit

83ccc07

[FIX] re-bugfix: ATSS head loss (openvinotoolkit#1907)

cd2519f

re bugfix

github-actions bot added ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests labels Mar 20, 2023

github-actions bot added the DOC Improvements or additions to documentation label Mar 20, 2023

supersoob requested review from JihwanEom, jaegukhyun, goodsong81 and harimkang March 20, 2023 09:46

supersoob marked this pull request as ready for review March 20, 2023 09:46

supersoob requested a review from a team as a code owner March 20, 2023 09:46

supersoob changed the base branch from develop to releases/1.1.0 March 20, 2023 09:48

chuneuny-emily added this to the 1.1.0 milestone Mar 20, 2023

Lee, Soobee added 10 commits March 20, 2023 22:25

docstring

a2c983d

Merge branch 'develop' of https://github.com/openvinotoolkit/training…

b199612

…_extensions into mpa-move

fix pylint

6f94f4e

otx precommit

a66d194

finish precommit issue

55b702f

tests revised

1f5091b

update docs

1617700

fix precommit

a220a15

fix year

d157ace

Merge branch 'releases/1.1.0' of https://github.com/openvinotoolkit/t…

fabbd4f

…raining_extensions into mpa-move

harimkang reviewed Mar 21, 2023

View reviewed changes

eunwoosh reviewed Mar 21, 2023

View reviewed changes

goodsong81 added ENHANCE Enhancement of existing features REFACTOR labels Mar 21, 2023

goodsong81 changed the title ~~[ENHANCE] Move semantic-segmentation related codes to otx adapters~~ Move semantic-segmentation related codes to otx adapters Mar 21, 2023

goodsong81 added the RELEASE label Mar 21, 2023

supersoob requested review from harimkang and eunwoosh March 21, 2023 02:20

eunwoosh approved these changes Mar 21, 2023

View reviewed changes

harimkang approved these changes Mar 21, 2023

View reviewed changes

supersoob enabled auto-merge (squash) March 21, 2023 04:52

JihwanEom mentioned this pull request Mar 21, 2023

Refactor OTX classification phase 1: move modules from MPA to OTX #1893

Merged

11 tasks

supersoob merged commit f8e1ced into openvinotoolkit:releases/1.1.0 Mar 21, 2023

Lee, Soobee added 6 commits March 21, 2023 18:22

test file

99fff4c

Merge branch 'releases/1.1.0' of https://github.com/openvinotoolkit/t…

a17a1cf

…raining_extensions into mpa-move

rebase

667d2b7

revise based on reviews

c25bd4e

unit tests

9882313

Merge branch 'releases/1.1.0' of https://github.com/openvinotoolkit/t…

98fd89c

…raining_extensions into mpa-move

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move semantic-segmentation related codes to otx adapters #1911

Move semantic-segmentation related codes to otx adapters #1911

supersoob commented Mar 20, 2023 •

edited

Loading

supersoob commented Mar 20, 2023

harimkang left a comment

eunwoosh left a comment

codecov-commenter commented Mar 21, 2023 •

edited

Loading

Move semantic-segmentation related codes to otx adapters #1911

Move semantic-segmentation related codes to otx adapters #1911

Conversation

supersoob commented Mar 20, 2023 • edited Loading

Summary

How to test

Checklist

License

supersoob commented Mar 20, 2023

harimkang left a comment

Choose a reason for hiding this comment

eunwoosh left a comment

Choose a reason for hiding this comment

codecov-commenter commented Mar 21, 2023 • edited Loading

Codecov Report

supersoob commented Mar 20, 2023 •

edited

Loading

codecov-commenter commented Mar 21, 2023 •

edited

Loading