Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add MoViNet template for action classification #1742

Merged
merged 16 commits into from
Mar 14, 2023
Merged

[FEATURE] Add MoViNet template for action classification #1742

merged 16 commits into from
Mar 14, 2023

Conversation

JihwanEom
Copy link
Contributor

@JihwanEom JihwanEom commented Feb 19, 2023 •
edited
Loading

  • Add template
  • Confirm MoViNet runs well
  • Refactor movinet.py
  • Resolve pre-commit issues
  • Add tests except movinet.py
  • Add tests for movinet.py

Test coverage

image

@github-actions github-actions bot added the ALGO Any changes in OTX Algo Tasks implementation label Feb 19, 2023
@JihwanEom JihwanEom changed the title [ENHANCE] Add MoViNet template for action classification [FEATURE] Add MoViNet template for action classification Feb 19, 2023
@harimkang harimkang added this to the 1.1.0 milestone Feb 20, 2023
@github-actions github-actions bot added BUILD DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM labels Mar 13, 2023
@github-actions github-actions bot added the TEST Any changes in tests label Mar 13, 2023
@JihwanEom JihwanEom changed the title [FEATURE] Add MoViNet template for action classification [FEATURE][WIP] Add MoViNet template for action classification Mar 13, 2023
@JihwanEom JihwanEom marked this pull request as ready for review March 13, 2023 03:20
@JihwanEom JihwanEom requested a review from a team as a code owner March 13, 2023 03:20
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2023 •
edited
Loading

Codecov Report

Patch coverage: 94.30% and project coverage change: +0.09 🎉

Comparison is base (3d56065) 80.52% compared to head (5f3cff5) 80.62%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1742      +/-   ##
===========================================
+ Coverage    80.52%   80.62%   +0.09%     
===========================================
  Files          484      486       +2     
  Lines        33005    33246     +241     
===========================================
+ Hits         26578    26805     +227     
- Misses        6427     6441      +14
Impacted Files Coverage Δ
...tion/adapters/mmaction/models/backbones/movinet.py 93.72% <93.72%> (ø)
...ion/adapters/mmaction/models/heads/movinet_head.py 94.11% <94.11%> (ø)
.../mmaction/models/recognizers/movinet_recognizer.py 100.00% <100.00%> (ø)

... and 12 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JihwanEom JihwanEom changed the title [FEATURE][WIP] Add MoViNet template for action classification [FEATURE] Add MoViNet template for action classification Mar 13, 2023
jaegukhyun
jaegukhyun previously approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@jaegukhyun jaegukhyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you for your effort!

@JihwanEom @nikita-savelyevv
Update otx/algorithms/action/adapters/mmaction/models/backbones/movin…
0dfb2eb 
…et.py

Co-authored-by: Nikita Savelyev <nikita.savelyev@intel.com>
@JihwanEom JihwanEom requested a review from jaegukhyun March 13, 2023 15:21
@JihwanEom JihwanEom merged commit 8b044b7 into develop Mar 14, 2023
@JihwanEom JihwanEom deleted the jeom/otx-movinet branch March 14, 2023 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaegukhyun jaegukhyun jaegukhyun approved these changes

@nikita-savelyevv nikita-savelyevv nikita-savelyevv approved these changes

@goodsong81 goodsong81 Awaiting requested review from goodsong81

@harimkang harimkang Awaiting requested review from harimkang

@sungmanc sungmanc Awaiting requested review from sungmanc

@supersoob supersoob Awaiting requested review from supersoob

@eunwoosh eunwoosh Awaiting requested review from eunwoosh

Assignees
No one assigned
Labels
ALGO Any changes in OTX Algo Tasks implementation BUILD DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM TEST Any changes in tests
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@JihwanEom @codecov-commenter @nikita-savelyevv @jaegukhyun @harimkang