-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Add FP16 IR export support #1683
Conversation
The CLI changes don't seem to be a problem :) |
98f9edc
to
a220999
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, no problem with export
CLI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I think we should not include this PR in this release as we need additional validation. Let's merge after code fix.
(No request change, but to prevent merge :))
6760e4a
to
8e1af9d
Compare
Codecov ReportBase: 78.44% // Head: 78.41% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1683 +/- ##
===========================================
- Coverage 78.44% 78.41% -0.04%
===========================================
Files 469 469
Lines 32833 32844 +11
===========================================
- Hits 25757 25753 -4
- Misses 7076 7091 +15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@goodsong81 @sungmanc I think we could consider merging this, since the release branch was created |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me, but I thing we should create FP16 export test
I'll address this in a separate PR, when FP16 inference on CI will be available. |
Flag
--half-precision
was added to the export tool.@harimkang @sungmanc please have a look at CLI changes