Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hackathon] Added notebook and utils for AI photo painting #1026

Conversation

ntk97
Copy link

@ntk97 ntk97 commented Apr 27, 2023

Added an AI photo painting notebook utilizing CocosNet and OpenVINO to synthesize a photo-realistic image based on exemplar image sketch semantic.

Signed-off-by: sarthakdeva-intel sarthak.deva@intel.com
Signed-off-by: shauryad15-intel  shaurya.dwivedi@intel.com
Signed-off-by: Vishwas R vishwas.r@intel.com
Signed-off-by: ntk nayana.tk@intel.com
Signed-off-by: aabhish1 abhishek.a@intel.com

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -0,0 +1,364 @@
{
Copy link
Collaborator

@eaidova eaidova Apr 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please provide more description e.g.

which model used,

diagram with pipeline work and its description


Reply via ReviewNB

@@ -0,0 +1,364 @@
{
Copy link
Collaborator

@eaidova eaidova Apr 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #6.    import gradio as gr

user can have not installed gradio as it is not listed in our requirements


Reply via ReviewNB

@@ -0,0 +1,364 @@
{
Copy link
Collaborator

@eaidova eaidova Apr 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please provide link for downloader documentation


Reply via ReviewNB

@@ -0,0 +1,364 @@
{
Copy link
Collaborator

@eaidova eaidova Apr 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #23.                # TODO: Remove this snippet if reference and input semantics are not required

are you plan to remove TODO?


Reply via ReviewNB

@@ -0,0 +1,364 @@
{
Copy link
Collaborator

@eaidova eaidova Apr 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #18.    demo.launch(share=True)

Is it possibly to use local instance if it Is applicable like in https://github.com/openvinotoolkit/openvino_notebooks/tree/main/notebooks/237-segment-anything

At least I think it is better to remove this cell output (now any person can run demo on your machine using provided link)


Reply via ReviewNB

@eaidova
Copy link
Collaborator

eaidova commented Apr 28, 2023

@ntk97 just friendly remind that your contribution should follow contribution guide

at the current moment, I see that this requirement does not met https://github.com/openvinotoolkit/openvino_notebooks/blob/main/CONTRIBUTING.md#readmes

as well as failing code check on ci speak about lining issues

@aabhish123 aabhish123 force-pushed the feature/ai_photo_team_2/cocosnet_model_notebook branch from 315b31d to 7f771dd Compare April 28, 2023 11:56
Added an AI photo painting notebook utilizing CocosNet
and OpenVINO to synthesize a photo-realistic image based
on exemplar image sketch semantic.

Signed-off-by: sarthakdeva-intel <sarthak.deva@intel.com>
Signed-off-by: shauryad15-intel  <shaurya.dwivedi@intel.com>
Signed-off-by: Vishwas R <vishwas.r@intel.com>
Signed-off-by: ntk <nayana.tk@intel.com>
Signed-off-by: aabhish1 <abhishek.a@intel.com>
@iamvishwas iamvishwas force-pushed the feature/ai_photo_team_2/cocosnet_model_notebook branch from 7f771dd to 7c8a57b Compare April 28, 2023 19:49
@iamvishwas iamvishwas force-pushed the feature/ai_photo_team_2/cocosnet_model_notebook branch from 5e5ec34 to 4066344 Compare May 3, 2023 09:56
@sarthakdeva-intel sarthakdeva-intel force-pushed the feature/ai_photo_team_2/cocosnet_model_notebook branch from 4066344 to 0a63651 Compare May 3, 2023 10:36
@AnishaUdayakumar
Copy link
Contributor

Thank you for your contribution. Please do the self-check first (copy the list and tick the item when it's done):

  • each function is described by docstrings and type hints
  • notebook contains explicit descriptions and explanatory diagrams
  • the notebook doesn't use any data (image, video, etc.) that is not CC4.0 licensed
  • there is a README.md file in consistent style (look at other notebooks)
  • the notebook is added to the main README
  • there are no grammar, punctuation or typo issues (use any free tool for that)
  • there are no committed files besides notebook and readme (please use images or videos from data dir)
  • your PR doesn't change any other notebooks
  • all CI checks passed

@@ -29,6 +29,9 @@ ipywidgets
ipykernel>=5.*
ipython>=7.16.3

# AI Painting notebook requirements
gradio==3.28.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please install gradio inside notebook

@adrianboguszewski
Copy link
Contributor

Thank you for your contribution. I'm closing this as the similar notebook has been just merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants