[JAVA] API 2.0 face detection demo #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@allnes please review |
dkurt
reviewed
Aug 25, 2022
dkurt
reviewed
Aug 25, 2022
| import org.opencv.core.*; | ||
| import org.opencv.highgui.HighGui; | ||
| import org.opencv.imgcodecs.*; | ||
| import org.opencv.imgproc.Imgproc; |
There was a problem hiding this comment.
I'd like recommend replace deprecated sample completely. It's OK to keep both APIs in the tests but samples should demonstrate the latest one.
There was a problem hiding this comment.
I agree, but I think we should first add async methods for Java API 2.0.
There was a problem hiding this comment.
These are two different demos so why not upgrade a synchronous sample first?
dkurt
reviewed
Aug 25, 2022
dkurt
reviewed
Aug 25, 2022
likholat
force-pushed
the
java_api_2.0_demo
branch
from
3cb2147
to
5050138
Compare
likholat
force-pushed
the
java_api_2.0_demo
branch
from
5050138
to
bc3e7b5
Compare
dkurt
approved these changes
Aug 26, 2022
ilya-lavrenov
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.