-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic plugin reshape blob #6969
Dynamic plugin reshape blob #6969
Conversation
…r Blob::setShape (a trivial one)
This reverts commit 71ee638.
...ence-engine/src/inference_engine/src/cpp_interfaces/interface/ie_iinfer_request_internal.cpp
Show resolved
Hide resolved
[VPU] Fixed allocating dynamic blobs in myriad_infer_request
@jane-intel @apankratovantonp @AlexeyLebedev1 Please take a look. |
bee38cd
to
0d5972d
Compare
inference-engine/tests/functional/plugin/shared/include/behavior/infer_request_dynamic.hpp
Show resolved
Hide resolved
inference-engine/tests/functional/plugin/shared/include/behavior/infer_request.hpp
Show resolved
Hide resolved
*/ | ||
static size_t properProduct(const SizeVector& dims) noexcept { | ||
return std::accumulate(std::begin(dims), std::end(dims), (size_t)1, std::multiplies<size_t>()); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can it be a lambda inside the setShape
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lower and upper bounds are hints. It is aux information that can be completely ignored by a plugin if it can work with generally dynamic dimensions w/o bounds.
} | ||
} | ||
_durations[Postprocess] = Time::now() - start; | ||
} | ||
// ! [infer_request:infer_postprocess] | ||
|
||
// ! [infer_request:get_blob] | ||
InferenceEngine::Blob::Ptr TemplateInferRequest::GetBlob(const std::string& name) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we also need to update documentation https://github.com/openvinotoolkit/openvino/blob/master/docs/IE_PLUGIN_DG/InferRequest.md
* Added nGraph as a public dependency * Fixed Windows warning * Fixed CMake * Fixed constant op * Fixed typo * Added reshape to PartialShape to CNNNetwork * Added SetShape to InferRequest * Enable support of DynamicShape in IE Data * Add support of dynamic shapes to template plugin * Fixed build * Enable support dynamic rank * Fixed test for dynamic rank * Fixed some tests * Fix preprocess tests * Fixed SetBlob * Fixed code style * Add more tests * Fixed accuracy tests * Fixed documentation * Added tests for custom operation * Added new tests * WIP: move setShape from infer request to Blob * Returned isApplicable check back * Removed obsolete tests for InferRequest::SetShape and add new test for Blob::setShape (a trivial one) * Fixed artifacts * Break code style * Revert "Break code style" This reverts commit 71ee638. * Added -j8 for fix_all * Applied code style fixes * Adde doxygen items * Fixed style * Applied codestyle patch * Reverted unrelevant commit with template extension * Fixed cmake file for shared func tests (pick from master) * Revert all changes in template_extension * Deleted some old stuff that commented and won't be used * Fixed wrong exception throwing * Code style fix * Fixed preprocessing part * Fixed incorrect blob reshape in GetBlob * Deleted incorrect assert in GAPI that prevents passing some tests in Debug * Fixed issues identified during review * Removed SetShape, replace getLayoutByDims by getLayoutByRank and removed problematic modification from IE preprocessing * Fixed comments * Removed obsolete setShape * [VPU] Fixed allocating dynamic blobs in myriad_infer_request * Fixed comments * Fixed CNNNgraphImpl and comments Co-authored-by: Ilya Churaev <ilya.churaev@intel.com> Co-authored-by: Polina <polina.brzezinskaya@intel.com>
Details:
Tickets: