Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic plugin reshape blob #6969

Merged

Conversation

slyalin
Copy link
Contributor

@slyalin slyalin commented Aug 6, 2021

Details:

  • Extended common IE API to support dynamic shapes
  • Add a support of dynamic cases for template plugin

Tickets:

  • ticket-id

@slyalin slyalin requested a review from mandrono August 23, 2021 13:04
ngraph/core/include/ngraph/op/parameter.hpp Outdated Show resolved Hide resolved
ngraph/core/include/ngraph/node.hpp Outdated Show resolved Hide resolved
[VPU] Fixed allocating dynamic blobs in myriad_infer_request
@slyalin slyalin requested a review from a team as a code owner August 26, 2021 18:38
@ilyachur
Copy link
Contributor

@jane-intel @apankratovantonp @AlexeyLebedev1 Please take a look.

*/
static size_t properProduct(const SizeVector& dims) noexcept {
return std::accumulate(std::begin(dims), std::end(dims), (size_t)1, std::multiplies<size_t>());
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can it be a lambda inside the setShape?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lower and upper bounds are hints. It is aux information that can be completely ignored by a plugin if it can work with generally dynamic dimensions w/o bounds.

}
}
_durations[Postprocess] = Time::now() - start;
}
// ! [infer_request:infer_postprocess]

// ! [infer_request:get_blob]
InferenceEngine::Blob::Ptr TemplateInferRequest::GetBlob(const std::string& name) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilya-lavrenov ilya-lavrenov merged commit bfae017 into openvinotoolkit:master Sep 1, 2021
ilyachur added a commit to ilyachur/openvino that referenced this pull request Sep 1, 2021
ilya-lavrenov pushed a commit that referenced this pull request Sep 1, 2021
akuporos pushed a commit to akuporos/openvino that referenced this pull request Sep 29, 2021
* Added nGraph as a public dependency

* Fixed Windows warning

* Fixed CMake

* Fixed constant op

* Fixed typo

* Added reshape to PartialShape to CNNNetwork

* Added SetShape to InferRequest

* Enable support of DynamicShape in IE Data

* Add support of dynamic shapes to template plugin

* Fixed build

* Enable support dynamic rank

* Fixed test for dynamic rank

* Fixed some tests

* Fix preprocess tests

* Fixed SetBlob

* Fixed code style

* Add more tests

* Fixed accuracy tests

* Fixed documentation

* Added tests for custom operation

* Added new tests

* WIP: move setShape from infer request to Blob

* Returned isApplicable check back

* Removed obsolete tests for InferRequest::SetShape and add new test for Blob::setShape (a trivial one)

* Fixed artifacts

* Break code style

* Revert "Break code style"

This reverts commit 71ee638.

* Added -j8 for fix_all

* Applied code style fixes

* Adde doxygen items

* Fixed style

* Applied codestyle patch

* Reverted unrelevant commit with template extension

* Fixed cmake file for shared func tests (pick from master)

* Revert all changes in template_extension

* Deleted some old stuff that commented and won't be used

* Fixed wrong exception throwing

* Code style fix

* Fixed preprocessing part

* Fixed incorrect blob reshape in GetBlob

* Deleted incorrect assert in GAPI that prevents passing some tests in Debug

* Fixed issues identified during review

* Removed SetShape, replace getLayoutByDims by getLayoutByRank and removed problematic modification from IE preprocessing

* Fixed comments

* Removed obsolete setShape

* [VPU] Fixed allocating dynamic blobs in myriad_infer_request

* Fixed comments

* Fixed CNNNgraphImpl and comments

Co-authored-by: Ilya Churaev <ilya.churaev@intel.com>
Co-authored-by: Polina <polina.brzezinskaya@intel.com>
akuporos pushed a commit to akuporos/openvino that referenced this pull request Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: inference OpenVINO Runtime library - Inference category: TEMPLATE OpenVINO Template plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants