[GNA] KSOFunction test fix #6678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreysapozhn
requested review from
nkogteva,
mryzhov,
dorloff,
elilobanova and
a team
openvino-pushbot
added
category: GNA
elilobanova
reviewed
Jul 16, 2021
| if (totalElements != totalWeights) { | ||
| THROW_GNA_EXCEPTION << l->name << " weights columns from transposition info (" << totalElements | ||
| << ") don't match input dimensions (" << totalWeights << ")"; | ||
| } |
There was a problem hiding this comment.
since this code is similar with one for FullyConnected layer I'd create a lambda function (something like transpInfoMatchWeightsSize) and call it in all required places
There was a problem hiding this comment.
ok, that makes sense
andreysapozhn
force-pushed
the
gna_kso_tests
branch
2 times, most recently
from
f17a35d
to
7f9d816
Compare
elilobanova
approved these changes
Jul 16, 2021
mryzhov
reviewed
Jul 19, 2021
| THROW_GNA_EXCEPTION << "For layer: " << l->name | ||
| << " weights size(" << weightsElements<< ") invalid: should match input size of(" << lastD << ")"; | ||
| } | ||
| // TODO: add broadcasting rules checks |
There was a problem hiding this comment.
Why not add those checks right now?
mryzhov
approved these changes
Jul 19, 2021
rnugmanx
pushed a commit
to rnugmanx/openvino
that referenced
this pull request
Aug 26, 2021
* [GNA] KSOFunction test fix * Lambda for dimensions matching check
andrei-cv
pushed a commit
to andrei-cv/openvino
that referenced
this pull request
Aug 30, 2021
* [GNA] KSOFunction test fix * Lambda for dimensions matching check
akuporos
pushed a commit
to akuporos/openvino
that referenced
this pull request
Sep 29, 2021
* [GNA] KSOFunction test fix * Lambda for dimensions matching check
tadamowicz
pushed a commit
to tadamowicz/openvino
that referenced
this pull request
Aug 30, 2023
* [GNA] KSOFunction test fix * Lambda for dimensions matching check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
SubstituteScaleShiftBroadCastPassgna_lugin.cppdue to dimensions inconsistency and memory errors inTransposeWeightsFromNCHWToNHWCPassTransposeWeightsFromNCHWToNHWCPassto avoid memory errors in futureEltwiseReshapeActivationtestKSOFunctiontest in GNA skip configTickets: