Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise PriorBoxClustered Spec #6539

Merged
merged 8 commits into from
Jul 19, 2021

Conversation

blesniewski
Copy link
Contributor

@blesniewski blesniewski commented Jul 6, 2021

Details:

  • Added a more detailed description to variances attribute
  • Moved detailed description up to match current standard for specification
  • Removed an attribute from specification that was not present anywhere in the code
  • Added backticks around attribute types and ranges

Tickets:

  • 45982
  • 37463

@blesniewski blesniewski self-assigned this Jul 6, 2021
@blesniewski blesniewski changed the title Revise pbc spec Revise PriorBoxClustered Spec Jul 8, 2021
@blesniewski blesniewski added this to the 2022.1 milestone Jul 8, 2021
@blesniewski blesniewski added the category: docs OpenVINO documentation label Jul 8, 2021
@blesniewski blesniewski marked this pull request as ready for review July 8, 2021 10:04
@blesniewski blesniewski requested a review from a team as a code owner July 8, 2021 10:04
@ilyachur ilyachur requested a review from rkazants July 12, 2021 03:16
@ilyachur
Copy link
Contributor

@rkazants Please have a look

@rkazants
Copy link
Contributor

@vgavrilo, could you please review it?

docs/ops/detection/PriorBoxClustered_1.md Outdated Show resolved Hide resolved
docs/ops/detection/PriorBoxClustered_1.md Outdated Show resolved Hide resolved
docs/ops/detection/PriorBoxClustered_1.md Outdated Show resolved Hide resolved
docs/ops/detection/PriorBoxClustered_1.md Show resolved Hide resolved
docs/ops/detection/PriorBoxClustered_1.md Show resolved Hide resolved
docs/ops/detection/PriorBoxClustered_1.md Show resolved Hide resolved
@ilyachur
Copy link
Contributor

Please resolve merge conflicts

@ilyachur ilyachur enabled auto-merge (squash) July 16, 2021 07:04
@ilyachur
Copy link
Contributor

@blesniewski Please resolve conflicts

@ilyachur ilyachur merged commit 4373b0c into openvinotoolkit:master Jul 19, 2021
rnugmanx pushed a commit to rnugmanx/openvino that referenced this pull request Aug 26, 2021
* Move detailed description up, add backtics to attr types

* Add backtics for range in clip attr description, remove non-existing attributes

* Adjusting the spec to review comments

* floating-point instead of floating point, remove default value for mandatory attribute
andrei-cv pushed a commit to andrei-cv/openvino that referenced this pull request Aug 30, 2021
* Move detailed description up, add backtics to attr types

* Add backtics for range in clip attr description, remove non-existing attributes

* Adjusting the spec to review comments

* floating-point instead of floating point, remove default value for mandatory attribute
akuporos pushed a commit to akuporos/openvino that referenced this pull request Sep 29, 2021
* Move detailed description up, add backtics to attr types

* Add backtics for range in clip attr description, remove non-existing attributes

* Adjusting the spec to review comments

* floating-point instead of floating point, remove default value for mandatory attribute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: docs OpenVINO documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants