Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LPT] Refactoring: PoC #5226

Merged
merged 4 commits into from
Jul 19, 2021
Merged

[LPT] Refactoring: PoC #5226

merged 4 commits into from
Jul 19, 2021

Conversation

eshoguli
Copy link
Contributor

@eshoguli eshoguli commented Apr 13, 2021 •
edited
Loading

Details:

  • Low Precision Transformation (LPT) component infrastructure and some transformations alignment to nGraph.

Tickets:

  • 42756

Validation:

  • 59717

@v-Golubev v-Golubev force-pushed the es/lpt/ngraph_refactoring branch 4 times, most recently from 6cef3ef to 837c32a Compare April 16, 2021 14:24
@eshoguli eshoguli force-pushed the es/lpt/ngraph_refactoring branch 4 times, most recently from b9eee08 to cacf0b1 Compare April 20, 2021 07:56
@eshoguli eshoguli force-pushed the es/lpt/ngraph_refactoring branch 3 times, most recently from 785007d to 152f12c Compare May 2, 2021 20:43
@v-Golubev v-Golubev force-pushed the es/lpt/ngraph_refactoring branch 2 times, most recently from 837c32a to 4e4dd08 Compare May 14, 2021 14:44
@eshoguli eshoguli force-pushed the es/lpt/ngraph_refactoring branch 4 times, most recently from 1d2e381 to 72af4dd Compare May 18, 2021 08:24
@v-Golubev v-Golubev force-pushed the es/lpt/ngraph_refactoring branch 4 times, most recently from 22003ad to 5150722 Compare May 25, 2021 21:16
@eshoguli eshoguli force-pushed the es/lpt/ngraph_refactoring branch 4 times, most recently from 97ea3f4 to c6b938d Compare June 18, 2021 12:52
@eshoguli eshoguli marked this pull request as ready for review July 13, 2021 11:09
@eshoguli eshoguli requested review from a team July 13, 2021 11:09
@eshoguli eshoguli requested review from a team as code owners July 13, 2021 11:09
@eshoguli eshoguli requested review from a team July 13, 2021 11:09
ilya-lavrenov and others added 2 commits July 15, 2021 17:18
@ilya-lavrenov @eshoguli
LPT fix for Windows
af290ca 
* LPT fix for Windows

* Remove inference_engine_transformations_EXPORTS
@eshoguli
[nGraph] Register new node in GraphRewrite
9b833a5
@eshoguli eshoguli force-pushed the es/lpt/ngraph_refactoring branch 4 times, most recently from 7f1cac2 to 90583c6 Compare July 16, 2021 12:24
@eshoguli eshoguli requested a review from jane-intel July 17, 2021 09:06
vladimir-paramuzov
vladimir-paramuzov approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@vladimir-paramuzov vladimir-paramuzov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPU part lgtm

dmitry-gorokhov
dmitry-gorokhov reviewed Jul 19, 2021
View reviewed changes
inference-engine/src/mkldnn_plugin/mkldnn_plugin.cpp
});

ngraph::pass::Manager lptManager;
lptManager.register_pass<ngraph::pass::low_precision::LowPrecision>(supportedPrecisions, perTensorQuantization);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocks the PR, but we still need to clarify which parameters are placed in base LPT API and which goes to callbacks.

dmitry-gorokhov
dmitry-gorokhov approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@dmitry-gorokhov dmitry-gorokhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve CPU part

@azhogov
Copy link

azhogov commented Jul 19, 2021

CI passed: https://github.com/intel-innersource/frameworks.ai.openvino.ci.product-configs/pull/13

@azhogov azhogov merged commit c3c26b4 into openvinotoolkit:master Jul 19, 2021
@v-Golubev v-Golubev mentioned this pull request Aug 20, 2021
Merged
rnugmanx pushed a commit to rnugmanx/openvino that referenced this pull request Aug 26, 2021
@eshoguli @ilya-lavrenov
[LPT] Refactoring: PoC (openvinotoolkit#5226)
d4efa94 
* LPT fix for Windows

* LPT fix for Windows

* Remove inference_engine_transformations_EXPORTS

* [nGraph] Register new node in GraphRewrite

* [LPT] nGraph alignment

* [LPT] nGraph alignment: tests

Co-authored-by: Ilya Lavrenov <ilya.lavrenov@intel.com>
andrei-cv pushed a commit to andrei-cv/openvino that referenced this pull request Aug 30, 2021
@eshoguli @ilya-lavrenov @andrei-cv
[LPT] Refactoring: PoC (openvinotoolkit#5226)
e8bf31d 
* LPT fix for Windows

* LPT fix for Windows

* Remove inference_engine_transformations_EXPORTS

* [nGraph] Register new node in GraphRewrite

* [LPT] nGraph alignment

* [LPT] nGraph alignment: tests

Co-authored-by: Ilya Lavrenov <ilya.lavrenov@intel.com>
akuporos pushed a commit to akuporos/openvino that referenced this pull request Sep 29, 2021
@eshoguli @ilya-lavrenov @akuporos
[LPT] Refactoring: PoC (openvinotoolkit#5226)
1ec6ff4 
* LPT fix for Windows

* LPT fix for Windows

* Remove inference_engine_transformations_EXPORTS

* [nGraph] Register new node in GraphRewrite

* [LPT] nGraph alignment

* [LPT] nGraph alignment: tests

Co-authored-by: Ilya Lavrenov <ilya.lavrenov@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitry-gorokhov dmitry-gorokhov dmitry-gorokhov approved these changes

@vladimir-paramuzov vladimir-paramuzov vladimir-paramuzov approved these changes

@jane-intel jane-intel jane-intel approved these changes

@vzinovie vzinovie Awaiting requested review from vzinovie

@GlebKazantaev GlebKazantaev Awaiting requested review from GlebKazantaev

Assignees
No one assigned
Labels
category: LP transformations OpenVINO Low Precision transformations
Projects
None yet
Milestone
2022.1
Development

Successfully merging this pull request may close these issues.
8 participants
@eshoguli @azhogov @dmitry-gorokhov @vladimir-paramuzov @GlebKazantaev @jane-intel @vzinovie @ilya-lavrenov