-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mem_peak_usage on macos #29241
Fix mem_peak_usage on macos #29241
Conversation
5dc4703
to
2c6eb2f
Compare
@wkobielx could you tell me how I can run macOS validation? |
@nikita-kud could you uncomment https://github.com/openvinotoolkit/openvino/blob/master/.github/workflows/mac.yml#L7-L25 for testing purposes? This way tests on mac will start for this PR automatically |
2c6eb2f
to
79551a7
Compare
79551a7
to
32703f6
Compare
I think, that get_peak_memory_usage could also work on Windows with python benchmark app, but you would need to add |
32703f6
to
1fad784
Compare
Thanks for your tip! I would prefer not to do that in this PR and limit it to fixing CI.. I can create a ticket for it, but I can't promise I'll take it. |
Samples on macos passed https://github.com/openvinotoolkit/openvino/actions/runs/13630253340/job/38096997067?pr=29241 |
1fad784
to
672036e
Compare
Done: CVS-163497 |
672036e
to
1df36d6
Compare
I don't think the PR is related to ie_tests_cldnn_unit_dg2_ubuntu22_release failure:
|
Restarted |
The description of the PR and the fix for python are taken here:
#29238
Faulty PR: #28931
Details:
Example failed jobs:
Tickets: