Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mem_peak_usage on macos #29241

Open
wants to merge 1 commit into from

Conversation

nikita-kud
Copy link
Contributor

The description of the PR and the fix for python are taken here:
#29238

Faulty PR: #28931

Details:

Example failed jobs:

Tickets:

@nikita-kud nikita-kud requested review from a team as code owners March 3, 2025 10:47
@nikita-kud nikita-kud requested review from ilya-lavrenov and removed request for a team March 3, 2025 10:47
@github-actions github-actions bot added category: samples OpenVINO Runtime Samples category: tools OpenVINO C++ / Python tools labels Mar 3, 2025
@nikita-kud nikita-kud requested review from Wovchena and wkobielx March 3, 2025 10:50
@nikita-kud
Copy link
Contributor Author

@wkobielx could you tell me how I can run macOS validation?

@wkobielx
Copy link
Contributor

wkobielx commented Mar 3, 2025

@nikita-kud could you uncomment https://github.com/openvinotoolkit/openvino/blob/master/.github/workflows/mac.yml#L7-L25 for testing purposes? This way tests on mac will start for this PR automatically

@nikita-kud nikita-kud requested a review from a team as a code owner March 3, 2025 11:09
@github-actions github-actions bot added category: CI OpenVINO public CI github_actions Pull requests that update GitHub Actions code labels Mar 3, 2025
@wkobielx
Copy link
Contributor

wkobielx commented Mar 3, 2025

I think, that get_peak_memory_usage could also work on Windows with python benchmark app, but you would need to add psutil package to test requirements https://github.com/openvinotoolkit/openvino/blob/master/tests/samples_tests/smoke_tests/requirements.txt

@nikita-kud
Copy link
Contributor Author

I think, that get_peak_memory_usage could also work on Windows with python benchmark app, but you would need to add psutil package to test requirements https://github.com/openvinotoolkit/openvino/blob/master/tests/samples_tests/smoke_tests/requirements.txt

Thanks for your tip! I would prefer not to do that in this PR and limit it to fixing CI.. I can create a ticket for it, but I can't promise I'll take it.

@wkobielx
Copy link
Contributor

wkobielx commented Mar 3, 2025

Samples on macos passed https://github.com/openvinotoolkit/openvino/actions/runs/13630253340/job/38096997067?pr=29241
c++ unit tests failed with different problem

@github-actions github-actions bot removed category: CI OpenVINO public CI github_actions Pull requests that update GitHub Actions code labels Mar 3, 2025
@nikita-kud nikita-kud requested a review from wkobielx March 3, 2025 15:14
@nikita-kud
Copy link
Contributor Author

I can create a ticket for it, but I can't promise I'll take it.

Done: CVS-163497

@nikita-kud
Copy link
Contributor Author

I don't think the PR is related to ie_tests_cldnn_unit_dg2_ubuntu22_release failure:

cldnn_unit_tests_dg2-0 INFO: FAILED TESTS (1/22808):
cldnn_unit_tests_dg2-0 INFO:      990 ms: /home/jenkins/agent/workspace/private-ci/ie/ie-tests-linux-ubuntu22-cldnn_unit_dg2/b/install/dldt_cpack/tests/ov_gpu_unit_tests convolution_int8_fw_gpu.quantized_convolution_u8s8f32_asymmetric_activations_per_channel_dynamic
cldnn_unit_tests_dg2-0 INFO: ========== Completed. Exit code: 1, elapsed time: 2352.252 sec, 0:39:12
cldnn_unit_tests_dg2-0 INFO: 
cldnn_unit_tests_dg2-0 WARNING: ========== ERRORS were not found in the output
cldnn_unit_tests_dg2-0 WARNING: ========== See full log for details regarding the errors
TaskTreeExec ERROR: Task 'cldnn_unit_tests_dg2-0' generated an exception: Task 'cldnn_unit_tests_dg2-0' - FAILED. Exit code: 1

@Wovchena
Copy link
Contributor

Wovchena commented Mar 4, 2025

Restarted

@nikita-kud
Copy link
Contributor Author

@wkobielx, @Wovchena can we merge it?

@Wovchena Wovchena added this pull request to the merge queue Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: samples OpenVINO Runtime Samples category: tools OpenVINO C++ / Python tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants