Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RTTI] Replace std::dynamic_(pointer)?_casts with ov::as_type_(ptr)? - Core, IE #28396

Merged
merged 6 commits into from
Jan 13, 2025
Merged

[RTTI] Replace std::dynamic_(pointer)?_casts with ov::as_type_(ptr)? - Core, IE #28396

merged 6 commits into from
Jan 13, 2025

Conversation

t-jankowski
Copy link
Contributor

@t-jankowski t-jankowski commented Jan 12, 2025 •
edited
Loading

Details:

  • Replaced std::dynamic_cast and std::dynamic_pointed_cast with ov::as_type or ov::as_type_ptr respectively in src/common, src/core and src/inference directories, where applicable.

Tickets:

@t-jankowski
Replace std dynamic casts with ov defined
5fd3a39 
std::dynamic_pointer_cast -> ov::as_type_ptr
std::dynamic_cast -> ov::as_type
Signed-off-by: Tomasz Jankowski <tomasz1.jankowski@intel.com>
@t-jankowski
Replace std dynamic casts with ov defined
6a1ecea 
std::dynamic_pointer_cast -> ov::as_type_ptr
std::dynamic_cast -> ov::as_type
Signed-off-by: Tomasz Jankowski <tomasz1.jankowski@intel.com>
@t-jankowski
Replace std dynamic casts with ov defined
988ff76 
std::dynamic_pointer_cast -> ov::as_type_ptr
std::dynamic_cast -> ov::as_type
Signed-off-by: Tomasz Jankowski <tomasz1.jankowski@intel.com>
@t-jankowski
Replace std dynamic casts with ov defined
cbca154 
Signed-off-by: Tomasz Jankowski <tomasz1.jankowski@intel.com>
@t-jankowski
Replace std dynamic casts with ov defined
0738908 
Signed-off-by: Tomasz Jankowski <tomasz1.jankowski@intel.com>
@t-jankowski t-jankowski requested review from a team as code owners January 12, 2025 20:33
@t-jankowski t-jankowski requested review from itikhono and removed request for a team January 12, 2025 20:33
@github-actions github-actions bot added category: inference OpenVINO Runtime library - Inference category: Core OpenVINO Core (aka ngraph) category: CPU OpenVINO CPU plugin category: transformations OpenVINO Runtime library - Transformations category: LP transformations OpenVINO Low Precision transformations category: CPP API OpenVINO CPP API bindings labels Jan 12, 2025
@t-jankowski t-jankowski requested a review from praasz January 12, 2025 20:33
@t-jankowski t-jankowski changed the title [RTTI] Replace std::dynamic_(pointer)?_casts with ov::as_type_(ptr)? [RTTI] Replace std::dynamic_(pointer)?_casts with ov::as_type_(ptr)? - Core, IE Jan 12, 2025
praasz
praasz approved these changes Jan 13, 2025
View reviewed changes
src/core/src/op/util/op_types.cpp Show resolved Hide resolved
@t-jankowski t-jankowski enabled auto-merge January 13, 2025 11:43
@t-jankowski t-jankowski added this to the 2025.0 milestone Jan 13, 2025
@t-jankowski t-jankowski added this pull request to the merge queue Jan 13, 2025
Merged via the queue into openvinotoolkit:master with commit 22922a2 Jan 13, 2025
190 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praasz praasz praasz approved these changes

@itikhono itikhono itikhono approved these changes

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

Assignees

@ilya-lavrenov ilya-lavrenov

Labels
category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings category: CPU OpenVINO CPU plugin category: inference OpenVINO Runtime library - Inference category: LP transformations OpenVINO Low Precision transformations category: transformations OpenVINO Runtime library - Transformations
Projects
None yet
Milestone
2025.0
Development

Successfully merging this pull request may close these issues.
4 participants
@t-jankowski @ilya-lavrenov @itikhono @praasz