Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GPU] Fix per-token dynamic quantization #27332

Merged
merged 1 commit into from
Oct 31, 2024
Merged

[GPU] Fix per-token dynamic quantization #27332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ...ns/intel_gpu/src/kernel_selector/kernels/dynamic_quantize/dynamic_quantize_kernel_opt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,13 @@ bool DynamicQuantizeKernelOpt::Validate(const Params& params) const {
if (dq_params.group_sizes.back() != UINT64_MAX)
return false;

if (!dq_params.scales_output_order.empty())
return false;
// Allow only default scales order
const auto& scales_output_order = dq_params.scales_output_order;
if (!scales_output_order.empty()) {
for (size_t i = 0; i < scales_output_order.size(); i++)
if (scales_output_order[i] != i)
return false;
}

return true;
}
Expand Down
11 changes: 5 additions & 6 deletions ...ns/intel_gpu/src/kernel_selector/kernels/dynamic_quantize/dynamic_quantize_kernel_ref.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@ JitConstants DynamicQuantizeKernelRef::GetJitConstants(const dynamic_quantize_pa
jit.AddConstant(MakeJitConstant("ASYMMETRIC_QUANTIZATION", params.use_asymmetric_quantization));
jit.AddConstant(MakeJitConstant("GROUP_SCALES_WITH_ZP", params.combine_scales_and_zp));

const auto& group_sizes = params.group_sizes;
auto group_sizes = params.group_sizes;
group_sizes.resize(std::min((size_t)4, group_sizes.size()), 1);

for (size_t i = 0; i < group_sizes.size(); i++) {
jit.AddConstant(MakeJitConstant("GROUP_SIZE_DIM" + std::to_string(i), group_sizes[i]));
}
Expand All @@ -68,7 +70,8 @@ CommonDispatchData DynamicQuantizeKernelRef::SetDefault(const dynamic_quantize_p

OPENVINO_ASSERT(params.outputs[0].GetLayout() == DataLayout::bfyx, "It supports only 4d tensor");

const auto& group_sizes = params.group_sizes;
auto group_sizes = params.group_sizes;
group_sizes.resize(std::min((size_t)4, group_sizes.size()), 1);
auto batch_size = group_sizes[0] == 1 ? params.outputs[0].Batch().v : 1;
auto feature_size = group_sizes[1] == 1 ? params.outputs[0].Feature().v : 1;
auto y_size = group_sizes[2] == 1 ? params.outputs[0].Y().v : 1;
Expand Down Expand Up @@ -134,10 +137,6 @@ bool DynamicQuantizeKernelRef::Validate(const Params& params) const {
if (!KernelBaseOpenCL::Validate(params))
return false;

const auto& prim_params = static_cast<const dynamic_quantize_params&>(params);
if (prim_params.group_sizes.size() != 4)
return false;

return true;
}
} // namespace kernel_selector
Loading