Remove duplicate backend registration from torch 2.5 #27245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: Python API
mvafin
reviewed
Oct 25, 2024
src/bindings/python/src/openvino/frontend/pytorch/torchdynamo/backend.py
Outdated
Show resolved
Hide resolved
mvafin
reviewed
Oct 25, 2024
src/bindings/python/src/openvino/frontend/pytorch/torchdynamo/backend.py
Outdated
Show resolved
Hide resolved
mvafin
reviewed
Oct 25, 2024
src/bindings/python/src/openvino/frontend/pytorch/torchdynamo/backend.py
Outdated
Show resolved
Hide resolved
rkazants
reviewed
Oct 25, 2024
Comment on lines
+64
to
+68
| from packaging import version | ||
|
|
||
| if version.parse(torch.__version__) < version.parse("2.5.0"): | ||
| register_backend(compiler_fn=openvino, name="openvino") | ||
| except ImportError: |
There was a problem hiding this comment.
may be it is better to check if backend is registered by this code?
if not hasattr(torch.backends, 'openvino') or not torch.backends.openvino.is_available()
that is torch version agnostic approach
There was a problem hiding this comment.
Agree, this can be improved. However I am not sure if the registered backends list can be easily accessible. Lets merge this PR as is and consider this improvement for future @suryasidd
mvafin
approved these changes
Oct 25, 2024
|
build_jenkins |
|
build_jenkins |
rkazants
approved these changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: