[Pytorch fronted]: Added support for Search Sorted op #26976

pkowalc1 · 2024-10-09T13:23:45Z

Details:

Added support for SearchSorted op with unittest.

Tickets:

CVS-154559

Depends on:

Co-authored-by: Pawel Raasz <pawel.raasz@intel.com>

….hpp Co-authored-by: Pawel Raasz <pawel.raasz@intel.com>

Co-authored-by: Pawel Raasz <pawel.raasz@intel.com>

…f impl.

openvinotoolkit#26884) Reverts openvinotoolkit#25780 Causes failures on master branch and in pull requests

…notoolkit#26768) ### Details: - Add check return value of node's evaluate in `ov::interval_bound_evaluator` function. This check allows to replace check if tensors are not empty (initialized), as when evaluate returns true the result is valid. ### Tickets: - CVS-153113

### Details: - Add definition of `OVAny` to `addon.ts` to encapsulate the concept of [ov::Any](https://docs.openvino.ai/2024/api/c_cpp_api/classov_1_1_any.html) from C++ API in a way that's clear and can be easily updated if the underlying C++ type changes. Improved readability and maintainability. -- 'OVAny' corresponds to Python API [OVAny](https://docs.openvino.ai/2024/api/ie_python_api/_autosummary/openvino.OVAny.html) - In future updates to Node.js API, the OVAny type is expected to be enhanced with additional functionality. - Missed linter changes to `core.test.js` due to upstream merges ### Tickets: - [CVS-149319](https://jira.devtools.intel.com/browse/CVS-149319)

…6865) ### Details: - *Add documentation for batching on NPU plugin* - *...* ### Tickets: - *EISW-118045* --------- Co-authored-by: Karol Blaszczak <karol.blaszczak@intel.com> Co-authored-by: Tatiana Savina <tatiana.savina@intel.com>

…toolkit#26869) ### Details: - *Add subgraph identificator for operation name, so one operation in two subgraphs can be distinguished as two different operations* - *...* ### Tickets: - *EISW-139849* --------- Co-authored-by: Dmitry Matveev <dmitry.matveev@intel.com>

…nce and adjust the NRMSE and PSNR metrics (openvinotoolkit#26020) ### Details: Small improvements for SIT: - Disable [dynamic quantization feature](https://github.com/openvinotoolkit/openvino/blob/master/src/inference/include/openvino/runtime/properties.hpp#L574), which is used by default by CPU pipeline to generate the reference outputs and affects accuracy for some particular models - Increase number of decimals for reported NRMSE metric to improve - For PSNR metric report fails only when the accuracy decrease not when it increase above the target ### Tickets: - *[CVS-143420](https://jira.devtools.intel.com/browse/CVS-143420)*

…penvinotoolkit#26848) ### Details: - Update `fc_bf_tiled_kernel_dyn_quan` for osv_is_yx_osv64_isv2 support ### Tickets: - 153232

…nd NumPy 2.X (openvinotoolkit#26886) **Details:** Run PT FE layer tests on Ubuntu 24.04 with Python 3.12 and NumPy 2.X Also, this PR contains fixes: - WA sporadic bug on Windows in case parallel run - support PT FE and TF FE layer tests on MacOS x86 - leftovers from code-review **Tickets:** 154003, 153800 --------- Signed-off-by: Kazantsev, Roman <roman.kazantsev@intel.com>

### Details: - Fix double constant definition

…otoolkit#26885) This PR adds unit tests on 1. unpack routines within NPUW 2. main online partitioning functionality (smaller unit tests on Graph, Group, Repeated, etc will be added separately) Brings back openvinotoolkit#25780 Local run: ``` [----------] Global test environment tear-down [==========] 334 tests from 6 test suites ran. (3379 ms total) [ PASSED ] 334 tests. ``` --------- Co-authored-by: Alexey Smirnov <alexey.smirnov@intel.com> Co-authored-by: Dmitry Matveev <dmitry.matveev@intel.com>

…olkit#26892) ### Details: - Support complex tensors for `ExpandDims` operation + tests ### Tickets: - [None](openvinotoolkit#22950)

### Details: - Debug code in network::execute() method is extracted to separate class/file to improve code readability

### Details: - Fix oob array

mmikolajcz · 2024-10-11T15:35:27Z

tests/layer_tests/pytorch_tests/test_search_sorted.py

+
+    @pytest.mark.nightly
+    @pytest.mark.precommit
+    @pytest.mark.parametrize(("sorted", "values"), [([[1, 3, 5, 7, 9], [2, 4, 6, 8, 10]], [[3, 6, 9], [3, 6, 9]]),([1, 3, 5, 7, 9], [[3, 6, 9],[0, 5, 20]])])


Given this op contains type promotion and input conversion done internally in torch may affect out values, maybe test data should include also few handpicked values with fractional part just to be sure?

Good point - will prepare a malicious case just for that

mvafin · 2024-10-14T12:00:49Z

src/frontends/pytorch/src/op/search_sorted.cpp

+    Output<Node> values;
+    std::tie(sorted, values) = get_inputs_with_promoted_types(context, 0, 1);
+    const bool out_int32 = context.const_input<bool>(2);
+    PYTORCH_OP_CONVERSION_CHECK(out_int32 == false, "aten::searchsorted(out_int32=true) unsupported");


Is it not just the output type of the operation? Can it be supported by just inserting Convert to i32?

It is a part of aten::searchsorted API and it is(that flag) not supported at the moment as it is not needed.

mvafin · 2024-10-14T12:05:48Z

src/frontends/pytorch/src/op/search_sorted.cpp

+    PYTORCH_OP_CONVERSION_CHECK(out_int32 == false, "aten::searchsorted(out_int32=true) unsupported");
+    const bool right_mode = context.const_input<bool>(3);
+    PYTORCH_OP_CONVERSION_CHECK(context.input_is_none(4), "aten::searchsorted(side) unsupported");
+    PYTORCH_OP_CONVERSION_CHECK(context.input_is_none(5), "aten::searchsorted(sorter) unsupported");


What index does out has? https://pytorch.org/docs/stable/generated/torch.searchsorted.html#torch-searchsorted

…ersion.

…thub.com/pkowalc1/openvino into add_search_sorted_op_to_pytroch_frontend

This reverts commit 6b9e286.

mmikolajcz · 2024-10-21T10:58:43Z

src/frontends/pytorch/src/op/search_sorted.cpp

+    PYTORCH_OP_CONVERSION_CHECK(out_int32 == false, "aten::searchsorted(out_int32=true) unsupported");
+    const bool right_mode = context.const_input<bool>(3);
+    PYTORCH_OP_CONVERSION_CHECK(context.input_is_none(4), "aten::searchsorted(side) unsupported");
+    PYTORCH_OP_CONVERSION_CHECK(context.input_is_none(5), "aten::searchsorted(out) unsupported");


Instead failing conversion with out please consider enabling it, for example like in round op: https://github.com/openvinotoolkit/openvino/blob/master/src/frontends/pytorch/src/op/round.cpp#L27-L29
+extend tests to cover such case:
https://github.com/openvinotoolkit/openvino/blob/master/tests/layer_tests/pytorch_tests/test_round.py#L34-L35

Same can be said about out_i32 which is just a Convert to i32

The task was to add minimal version that supports some roblox model - not a full scale op. out_i32 parameter and out parameter are not used in that model and as such are omitted. If needed - they can be always enabled later with proper testing etc.

The original deadline for enabling this minimal version is today(22 Oct 2024). This PR has been in review for 2 weeks now - if you don't see any issues for minimal version which is now in this PR, please pass it.

I'm supporting this approach
Please create a list of leftovers/improvements we could pickup in a scope of next release. For this one let's focus on specific request to deliver it on time.

That is fine, just please ensure we have a ticket for improved support

pkowalc1 · 2024-10-23T13:37:01Z

Dear reviewers, if you do not see any serious issues with this PR - please approve it, or add proper comment.

pkowalc1 · 2024-10-24T10:44:30Z

NOTE: Failing tests on ARM is a known issue and will be fixed after #27217 is merged.

pkowalc1 and others added 30 commits October 2, 2024 12:25

[Spec]: Added initial specification of Searchsorted op

187f1c4

[op]: S[SearchSorted]: Added new op definition with tests.

ccb2134

Merge branch 'master' into search_sorted_op_def

ef5d369

[unittest]:[SearchSorted]: Fix Windows warnings.

c87ed2f

Update src/core/include/openvino/op/search_sorted.hpp

5987b73

Co-authored-by: Pawel Raasz <pawel.raasz@intel.com>

Update src/core/shape_inference/include/search_sorted_shape_inference…

ddee155

….hpp Co-authored-by: Pawel Raasz <pawel.raasz@intel.com>

Update src/core/shape_inference/include/search_sorted_shape_inference…

58cfcdd

….hpp Co-authored-by: Pawel Raasz <pawel.raasz@intel.com>

Update src/core/include/openvino/op/search_sorted.hpp

7663026

Co-authored-by: Pawel Raasz <pawel.raasz@intel.com>

[SortedSearch]: Fixed validation due to review and added more unittests.

60984a6

[attributes_test]: Added test for SearchSorted op.

420b709

[SearchSorted]: Fixed code style.

60eff69

Removed search_sorted.rst in order to not block PR contiaining the de…

a33b7f9

…f impl.

Removed search_sorted.rst in order to not block PR contiaining the de…

cd3873d

…f impl.

Merge branch 'master' into search_sorted_op_def

6b80399

[ref]: Added SearchSorted ref impl.

f7b82e0

[Spec]: Added initial specification of Searchsorted op

cb6531a

[op]: S[SearchSorted]: Added new op definition with tests.

80b6c25

Revert "[NPUW] Add initial unpack and partitioning unit tests on NPUW" (

cf87e7a

openvinotoolkit#26884) Reverts openvinotoolkit#25780 Causes failures on master branch and in pull requests

[GPU] Support large N FC optimization for dynamic quantization case (o…

1939b8f

…penvinotoolkit#26848) ### Details: - Update `fc_bf_tiled_kernel_dyn_quan` for osv_is_yx_osv64_isv2 support ### Tickets: - 153232

[GPU] Fix double jit constants (openvinotoolkit#26893)

94aff1e

### Details: - Fix double constant definition

[TF FE]: Support complex tensors for ExpandDims operation (openvinoto…

ad0b980

…olkit#26892) ### Details: - Support complex tensors for `ExpandDims` operation + tests ### Tickets: - [None](openvinotoolkit#22950)

[GPU] Extract debug code from network::execute() (openvinotoolkit#26888)

f6ba78f

### Details: - Debug code in network::execute() method is extracted to separate class/file to improve code readability

[GPU] Fix unit tests ph4 (openvinotoolkit#26879)

0ac600b

### Details: - Fix oob array

pkowalc1 changed the title ~~[Pytorch fronted]: Added support for Search Sorted op.~~ [Pytorch fronted]: Added support for Search Sorted op Oct 11, 2024

mmikolajcz reviewed Oct 11, 2024

View reviewed changes

mvafin reviewed Oct 14, 2024

View reviewed changes

pkowalc1 and others added 5 commits October 17, 2024 07:42

[pytorch]: SearchSorted: review fixes.

4cee5bd

[pytorch]: SearchSorted unittests: added malicios test cases for conv…

9765fa3

…ersion.

Merge branch 'master' into add_search_sorted_op_to_pytroch_frontend

9b782f3

TEMPORARY COMMIT TO TEST CI

6b9e286

Merge branch 'add_search_sorted_op_to_pytroch_frontend' of https://gi…

8b4824c

…thub.com/pkowalc1/openvino into add_search_sorted_op_to_pytroch_frontend

pkowalc1 requested a review from a team as a code owner October 18, 2024 12:09

github-actions bot added category: CI OpenVINO public CI github_actions Pull requests that update GitHub Actions code labels Oct 18, 2024

Revert "TEMPORARY COMMIT TO TEST CI"

71ee38a

This reverts commit 6b9e286.

github-actions bot removed category: CI OpenVINO public CI github_actions Pull requests that update GitHub Actions code labels Oct 21, 2024

Merge branch 'master' into add_search_sorted_op_to_pytroch_frontend

b179570

mmikolajcz reviewed Oct 21, 2024

View reviewed changes

Merge branch 'master' into add_search_sorted_op_to_pytroch_frontend

d61f3dd

mlukasze requested review from mvafin and mmikolajcz October 24, 2024 04:45

p-wysocki approved these changes Oct 24, 2024

View reviewed changes

[Pytorch frontend]: SearchSorted test: fixed fail on cpu plugin.

fbc8f32

mlukasze enabled auto-merge October 24, 2024 10:50

mmikolajcz approved these changes Oct 24, 2024

View reviewed changes

mlukasze added this pull request to the merge queue Oct 24, 2024

Merged via the queue into openvinotoolkit:master with commit 6a8a69c Oct 24, 2024
156 of 159 checks passed

pkowalc1 deleted the add_search_sorted_op_to_pytroch_frontend branch October 30, 2024 07:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Pytorch fronted]: Added support for Search Sorted op #26976

[Pytorch fronted]: Added support for Search Sorted op #26976

pkowalc1 commented Oct 9, 2024 •

edited

Loading

mmikolajcz Oct 11, 2024

pkowalc1 Oct 17, 2024

pkowalc1 Oct 17, 2024

mvafin Oct 14, 2024

pkowalc1 Oct 17, 2024

mvafin Oct 14, 2024

pkowalc1 Oct 17, 2024

mmikolajcz Oct 21, 2024

mvafin Oct 21, 2024

pkowalc1 Oct 22, 2024 •

edited

Loading

mlukasze Oct 22, 2024

mvafin Oct 22, 2024

mlukasze Oct 22, 2024

pkowalc1 commented Oct 23, 2024

pkowalc1 commented Oct 24, 2024

[Pytorch fronted]: Added support for Search Sorted op #26976

[Pytorch fronted]: Added support for Search Sorted op #26976

Conversation

pkowalc1 commented Oct 9, 2024 • edited Loading

Details:

Tickets:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pkowalc1 Oct 22, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pkowalc1 commented Oct 23, 2024

pkowalc1 commented Oct 24, 2024

pkowalc1 commented Oct 9, 2024 •

edited

Loading

pkowalc1 Oct 22, 2024 •

edited

Loading