Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GHA][PE FE][TF FE] Create separate GHA job for PyTorch layer tests and stick exact versions for all deps #26856

Merged
merged 18 commits into from
Oct 1, 2024
Merged

[GHA][PE FE][TF FE] Create separate GHA job for PyTorch layer tests and stick exact versions for all deps #26856

merged 18 commits into from
Oct 1, 2024

Conversation

rkazants
Copy link
Contributor

@rkazants rkazants commented Sep 30, 2024 •
edited
Loading

Details: Create separate GHA job for PyTorch layer tests and stick exact versions for all deps

Ticket: 153800

@rkazants
[OVC] Support Numpy 2 by OVC
e79ed0f 
Signed-off-by: Kazantsev, Roman <roman.kazantsev@intel.com>
@rkazants rkazants requested review from a team as code owners September 30, 2024 09:37
@rkazants rkazants requested review from akuporos and artanokhov and removed request for a team September 30, 2024 09:37
@github-actions github-actions bot added category: Python API OpenVINO Python bindings category: dependency_changes Pull requests that update a dependency file labels Sep 30, 2024
@rkazants rkazants changed the title [OVC] Support Numpy 2 by OVC [OVC][DO NOT MERGE] Support Numpy 2 by OVC Sep 30, 2024
@rkazants rkazants changed the title [OVC][DO NOT MERGE] Support Numpy 2 by OVC [OVC][DO NOT MERGE] Support NumPy 2 by OVC Sep 30, 2024
@rkazants
Not sure that h5py is needed
76cacf7 
Signed-off-by: Kazantsev, Roman <roman.kazantsev@intel.com>
@github-actions github-actions bot added the category: TF FE OpenVINO TensorFlow FrontEnd label Sep 30, 2024
@rkazants
Create separate requirements files for Pytorch and TensorFlow support…
3b44637 
… validation

Signed-off-by: Kazantsev, Roman <roman.kazantsev@intel.com>
@rkazants rkazants requested a review from a team as a code owner September 30, 2024 16:22
@github-actions github-actions bot added category: CI OpenVINO public CI github_actions Pull requests that update GitHub Actions code labels Sep 30, 2024
@rkazants rkazants changed the title [OVC][DO NOT MERGE] Support NumPy 2 by OVC [OVC] Support NumPy 2 by OVC Sep 30, 2024
rkazants
rkazants commented Sep 30, 2024
View reviewed changes
tests/constraints.txt Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the category: Python API OpenVINO Python bindings label Sep 30, 2024
@github-actions github-actions bot added the category: build OpenVINO cmake script / infra label Sep 30, 2024
mvafin
mvafin reviewed Oct 1, 2024
View reviewed changes
tests/requirements_pytorch Outdated Show resolved Hide resolved
rkazants and others added 2 commits October 1, 2024 13:00
@rkazants @mvafin
Update tests/requirements_pytorch
5827fa9 
Co-authored-by: Maxim Vafin <maxim.vafin@intel.com>
@rkazants
Stick exact version via ==
2d53b76 
Signed-off-by: Kazantsev, Roman <roman.kazantsev@intel.com>
@rkazants rkazants requested a review from mvafin October 1, 2024 09:06
@rkazants rkazants changed the title [OVC] Support NumPy 2 by OVC [OVC] Create separate GHA job for PyTorch layer tests and stick exact versions for all deps Oct 1, 2024
@rkazants rkazants changed the title [OVC] Create separate GHA job for PyTorch layer tests and stick exact versions for all deps [GHA][PE FE][TF FE] Create separate GHA job for PyTorch layer tests and stick exact versions for all deps Oct 1, 2024
@rkazants rkazants requested a review from akashchi October 1, 2024 09:33
akashchi
akashchi approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@akashchi akashchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GHA changes LGTM except for 2 possible improvements.

.github/workflows/job_pytorch_layer_tests.yml

env:
PIP_CACHE_PATH: /mount/caches/pip/linux
PYTHON_VERSION: '3.11'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest moving it to the inputs like in

openvino/.github/workflows/job_python_unit_tests.yml

Line 19 in 2507d89

python-version:
so that it would be possible to test on different Python versions in different workflows.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me fix in separate PR.

.github/workflows/job_pytorch_layer_tests.yml
Comment on lines +10 to +13
shell:
description: "shell to override the default shell settings in the runner's operating system."
type: string
required: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be done directly in the shell of the job definition like in

openvino/.github/workflows/job_cxx_unit_tests.yml

Line 31 in 2507d89

shell: ${{ contains(inputs.runner, 'win') && 'pwsh' || 'bash' }}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me fix in separate PR.

@rkazants rkazants added this pull request to the merge queue Oct 1, 2024
@rkazants rkazants added this to the 2024.5 milestone Oct 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 1, 2024
@rkazants rkazants added this pull request to the merge queue Oct 1, 2024
Merged via the queue into openvinotoolkit:master with commit d2a9873 Oct 1, 2024
157 checks passed
@rkazants rkazants deleted the enable_numpy20_for_ovc branch October 1, 2024 16:17
ilya-lavrenov
ilya-lavrenov reviewed Oct 7, 2024
View reviewed changes
tests/requirements_tensorflow
tensorflow-text==2.17.0; platform_system == "Linux" and platform_machine == "x86_64"
tensorflow-hub==0.16.1
jax==0.4.33
defusedxml==0.7.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you considered pyproject.toml files and using Poetry and python frontend / backend?

@mvafin mvafin mentioned this pull request Oct 24, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 24, 2024
@mvafin
[TESTS] Remove unused requirements.txt (#27235)
9b377f4 
### Details:
 - *requirements.txt from pytorch hub tests are unused after #26856 *

### Tickets:
 - *CVS-155878*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-lavrenov ilya-lavrenov ilya-lavrenov left review comments

@mvafin mvafin mvafin approved these changes

@akashchi akashchi akashchi approved these changes

@akuporos akuporos Awaiting requested review from akuporos akuporos is a code owner automatically assigned from openvinotoolkit/openvino-configuration-mgmt

@artanokhov artanokhov Awaiting requested review from artanokhov artanokhov is a code owner automatically assigned from openvinotoolkit/openvino-configuration-mgmt

@gkrivor gkrivor Awaiting requested review from gkrivor

@popovaan popovaan Awaiting requested review from popovaan

Assignees
No one assigned
Labels
category: build OpenVINO cmake script / infra category: CI OpenVINO public CI category: dependency_changes Pull requests that update a dependency file category: TF FE OpenVINO TensorFlow FrontEnd github_actions Pull requests that update GitHub Actions code no-match-files
Projects
None yet
Milestone
2024.5
Development

Successfully merging this pull request may close these issues.
4 participants
@rkazants @ilya-lavrenov @mvafin @akashchi