Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#20927 support inputs that have no batch #26778

Merged
merged 10 commits into from
Oct 17, 2024
Merged

#20927 support inputs that have no batch #26778

merged 10 commits into from
Oct 17, 2024

Conversation

tianyiSKY1
Copy link
Contributor

#20927

Details:

  • add batch dimension before pool
  • remove batch dimension after pool

@tianyiSKY1 tianyiSKY1 requested a review from a team as a code owner September 25, 2024 07:31
@github-actions github-actions bot added the category: PyTorch FE OpenVINO PyTorch Frontend label Sep 25, 2024
@sys-openvino-ci sys-openvino-ci added the ExternalPR External contributor label Sep 25, 2024
mvafin
mvafin requested changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@mvafin mvafin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix code style

src/frontends/pytorch/src/op_table.cpp Outdated Show resolved Hide resolved
@tianyiSKY1 tianyiSKY1 requested a review from mvafin September 25, 2024 12:53
@tianyiSKY1 tianyiSKY1 requested a review from mvafin September 26, 2024 01:31
mvafin
mvafin requested changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@mvafin mvafin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix code style

src/frontends/pytorch/src/op/max_poolnd.cpp Show resolved Hide resolved
src/frontends/pytorch/src/op/max_poolnd.cpp Outdated Show resolved Hide resolved
@tianyiSKY1 tianyiSKY1 requested a review from mvafin September 29, 2024 14:41
@tianyiSKY1
Copy link
Contributor Author

@mvafin Hello, Is there any problem with my code?

mvafin
mvafin requested changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@mvafin mvafin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use existing test_pooling.py for your tests or remove it to create test_avg_pool.py and test_max_pool.py

tests/layer_tests/pytorch_tests/test_avg_pool.py Outdated Show resolved Hide resolved
@mvafin
Copy link
Contributor

mvafin commented Oct 8, 2024

Please fix code style

@tianyiSKY1 tianyiSKY1 requested a review from mvafin October 10, 2024 08:41
mvafin
mvafin reviewed Oct 10, 2024
View reviewed changes
Copy link
Contributor

@mvafin mvafin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tianyiSKY1 Tests are passing, but you still have code style issues. Please fix them.
You can fix the code style automatically as written here:

openvino/docs/dev/coding_style.md

Line 11 in 3f70084

If all dependencies are resolved, you can use the `clang_format_fix_all` target to fix all code style issues.

@tianyiSKY1 tianyiSKY1 requested a review from mvafin October 11, 2024 09:21
@mvafin
Copy link
Contributor

mvafin commented Oct 11, 2024

build_jenkins

mvafin
mvafin approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@mvafin mvafin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. @tianyiSKY1 thank you for contribution!

@tianyiSKY1
Copy link
Contributor Author

Looks good. @tianyiSKY1 thank you for contribution!

Thank you for all the guidance you've been giving me lately, I've learned a lot!

@mvafin
Copy link
Contributor

mvafin commented Oct 14, 2024

build_jenkins

@mvafin
Copy link
Contributor

mvafin commented Oct 16, 2024

@tianyiSKY1 please do not merge master. It restarts all CI, it is not needed for your changes.

@mvafin
Copy link
Contributor

mvafin commented Oct 16, 2024

build_jenkins

@mvafin mvafin added this pull request to the merge queue Oct 17, 2024
Merged via the queue into openvinotoolkit:master with commit 8822480 Oct 17, 2024
160 checks passed
@mlukasze mlukasze added this to the 2024.5 milestone Oct 21, 2024
@jikechao jikechao mentioned this pull request Dec 20, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvafin mvafin mvafin approved these changes

@PiotrKrzem PiotrKrzem Awaiting requested review from PiotrKrzem PiotrKrzem is a code owner automatically assigned from openvinotoolkit/openvino-pytorch-frontend-maintainers

Assignees
No one assigned
Labels
category: PyTorch FE OpenVINO PyTorch Frontend ExternalPR External contributor
Projects
None yet
Milestone
2024.5
Development

Successfully merging this pull request may close these issues.
4 participants
@tianyiSKY1 @mvafin @mlukasze @sys-openvino-ci