[Snippets] extract invariants pass #24044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenhu-wang
force-pushed
the
chenhu/snippets_extractLoopInvariants_lower_pass
branch
4 times, most recently
from
11e4faf
to
166390a
Compare
chenhu-wang
force-pushed
the
chenhu/snippets_extractLoopInvariants_lower_pass
branch
3 times, most recently
from
d5594f2
to
4e018b8
Compare
a-sidorova
reviewed
May 1, 2024
src/common/snippets/src/lowered/pass/extract_loop_invariants.cpp
Outdated
Show resolved
Hide resolved
chenhu-wang
force-pushed
the
chenhu/snippets_extractLoopInvariants_lower_pass
branch
3 times, most recently
from
945d406
to
253ba95
Compare
chenhu-wang
force-pushed
the
chenhu/snippets_extractLoopInvariants_lower_pass
branch
5 times, most recently
from
62fc07b
to
d949778
Compare
a-sidorova
reviewed
May 24, 2024
There was a problem hiding this comment.
First part of review is completed
My major comment (suggestion): need to split code into semantic blocks: the separate functions.
When you see the body of the function with 200 code lines, it's very difficult to review and maintain 😢
In the best scenario the developer can read the code as a book by chapters (functions) 😃
src/common/snippets/src/lowered/pass/extract_loop_invariants.cpp
Outdated
Show resolved
Hide resolved
src/common/snippets/src/lowered/pass/extract_loop_invariants.cpp
Outdated
Show resolved
Hide resolved
src/common/snippets/src/lowered/pass/extract_loop_invariants.cpp
Outdated
Show resolved
Hide resolved
src/common/snippets/src/lowered/pass/extract_loop_invariants.cpp
Outdated
Show resolved
Hide resolved
src/common/snippets/src/lowered/pass/extract_loop_invariants.cpp
Outdated
Show resolved
Hide resolved
src/common/snippets/src/lowered/pass/extract_loop_invariants.cpp
Outdated
Show resolved
Hide resolved
src/common/snippets/src/lowered/pass/extract_loop_invariants.cpp
Outdated
Show resolved
Hide resolved
src/common/snippets/src/lowered/pass/extract_loop_invariants.cpp
Outdated
Show resolved
Hide resolved
src/common/snippets/src/lowered/pass/extract_loop_invariants.cpp
Outdated
Show resolved
Hide resolved
a-sidorova
reviewed
May 24, 2024
src/common/snippets/src/lowered/pass/extract_loop_invariants.cpp
Outdated
Show resolved
Hide resolved
src/common/snippets/src/lowered/pass/extract_loop_invariants.cpp
Outdated
Show resolved
Hide resolved
src/common/snippets/src/lowered/pass/extract_loop_invariants.cpp
Outdated
Show resolved
Hide resolved
src/common/snippets/src/lowered/pass/extract_loop_invariants.cpp
Outdated
Show resolved
Hide resolved
src/common/snippets/src/lowered/pass/extract_loop_invariants.cpp
Outdated
Show resolved
Hide resolved
src/common/snippets/src/lowered/pass/extract_loop_invariants.cpp
Outdated
Show resolved
Hide resolved
src/common/snippets/include/snippets/lowered/pass/extract_loop_invariants.hpp
Outdated
Show resolved
Hide resolved
chenhu-wang
force-pushed
the
chenhu/snippets_extractLoopInvariants_lower_pass
branch
3 times, most recently
from
ccbc9c7
to
015a5ae
Compare
a-sidorova
reviewed
Jun 3, 2024
src/common/snippets/include/snippets/lowered/pass/extract_loop_invariants.hpp
Outdated
Show resolved
Hide resolved
src/common/snippets/include/snippets/lowered/pass/extract_loop_invariants.hpp
Outdated
Show resolved
Hide resolved
src/common/snippets/src/lowered/pass/extract_loop_invariants.cpp
Outdated
Show resolved
Hide resolved
src/common/snippets/tests/src/lowered/pass/extracte_loop_invariants.cpp
Outdated
Show resolved
Hide resolved
src/common/snippets/tests/src/lowered/pass/extracte_loop_invariants.cpp
Outdated
Show resolved
Hide resolved
src/common/snippets/tests/src/lowered/pass/extracte_loop_invariants.cpp
Outdated
Show resolved
Hide resolved
src/common/snippets/tests/src/lowered/pass/extracte_loop_invariants.cpp
Outdated
Show resolved
Hide resolved
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
chenhu-wang
force-pushed
the
chenhu/snippets_extractLoopInvariants_lower_pass
branch
2 times, most recently
from
ac972d6
to
17b1f22
Compare
… position of load
chenhu-wang
force-pushed
the
chenhu/snippets_extractLoopInvariants_lower_pass
branch
from
17b1f22
to
e5fef48
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
Reverts #24044 Reverted due to failure in TF FE layer tests: RuntimeError: Exception from openvino\openvino\src\inference\src\cpp\core.cpp:107: Exception from openvino\openvino\src\inference\src\dev\plugin.cpp:53: Exception from openvino\openvino\src\common\snippets\src\lowered\pass\assign_registers.cpp:315: can't allocate registers for a snippet
This was referenced Jun 25, 2024
allnes
pushed a commit
to allnes/openvino
that referenced
this pull request
Jun 27, 2024
### Details: - *extract invariants pass* ### Tickets: - *CVS-136160* ### Todo: - [x] Add LIR correctness check test
allnes
pushed a commit
to allnes/openvino
that referenced
this pull request
Jun 27, 2024
Reverts openvinotoolkit#24044 Reverted due to failure in TF FE layer tests: RuntimeError: Exception from openvino\openvino\src\inference\src\cpp\core.cpp:107: Exception from openvino\openvino\src\inference\src\dev\plugin.cpp:53: Exception from openvino\openvino\src\common\snippets\src\lowered\pass\assign_registers.cpp:315: can't allocate registers for a snippet
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 3, 2024
### Details: - *recreation for PR #24044 - *fix post commit fail(will be added in pre commit soon)* ### Tickets: - *CVS-136160*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets:
Todo: