Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Op] Add RMSNorm op core class #23842

Merged
merged 37 commits into from
Apr 15, 2024
Merged

[Op] Add RMSNorm op core class #23842

merged 37 commits into from
Apr 15, 2024

Conversation

mitruska
Copy link
Contributor

@mitruska mitruska commented Apr 3, 2024 •
edited
Loading

Details:

  • RMSNorm op core class
  • Registration in the opset and op check (conformance) test will be added in the next PRs

Spec PR:

Tickets:

  • 136261

@mitruska mitruska requested review from a team as code owners April 3, 2024 14:37
@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: CPU OpenVINO CPU plugin category: CPP API OpenVINO CPP API bindings labels Apr 3, 2024
@mitruska mitruska added the category: Opset OpenVINO Opset label Apr 3, 2024
@mitruska mitruska self-assigned this Apr 3, 2024
@mitruska mitruska added this to the 2024.2 milestone Apr 3, 2024
praasz
praasz requested changes Apr 4, 2024
View reviewed changes
src/core/src/op/rms_norm.cpp Outdated Show resolved Hide resolved
src/core/src/op/rms_norm.cpp Outdated Show resolved Hide resolved
src/plugins/intel_cpu/tests/unit/shape_inference_test/rms_norm_shape_inference_test.cpp Show resolved Hide resolved
src/plugins/intel_cpu/tests/unit/shape_inference_test/rms_norm_shape_inference_test.cpp Outdated Show resolved Hide resolved
src/core/include/openvino/op/rms_norm.hpp Show resolved Hide resolved
src/core/tests/type_prop/rms_norm.cpp Outdated Show resolved Hide resolved
src/plugins/intel_cpu/src/shape_inference/shape_inference.cpp Outdated Show resolved Hide resolved
src/plugins/intel_cpu/tests/unit/shape_inference_test/rms_norm_shape_inference_test.cpp Show resolved Hide resolved
src/plugins/intel_cpu/tests/unit/shape_inference_test/rms_norm_shape_inference_test.cpp Show resolved Hide resolved
src/core/include/openvino/op/rms_norm.hpp Show resolved Hide resolved
@mitruska mitruska requested a review from praasz April 9, 2024 13:47
praasz
praasz requested changes Apr 12, 2024
View reviewed changes
src/core/include/openvino/op/rms_norm.hpp Show resolved Hide resolved
src/core/shape_inference/include/rms_norm_shape_inference.hpp Outdated Show resolved Hide resolved
src/core/src/op/rms_norm.cpp Outdated Show resolved Hide resolved
src/core/tests/type_prop/rms_norm.cpp Outdated Show resolved Hide resolved
src/core/tests/type_prop/rms_norm.cpp Show resolved Hide resolved
src/core/shape_inference/include/rms_norm_shape_inference.hpp Outdated Show resolved Hide resolved
src/core/src/op/rms_norm.cpp Show resolved Hide resolved
@mitruska mitruska requested a review from praasz April 12, 2024 12:00
praasz
praasz approved these changes Apr 12, 2024
View reviewed changes
src/core/include/openvino/op/rms_norm.hpp Show resolved Hide resolved
src/core/tests/type_prop/rms_norm.cpp Show resolved Hide resolved
@mitruska mitruska added this pull request to the merge queue Apr 15, 2024
Merged via the queue into openvinotoolkit:master with commit 5098aca Apr 15, 2024
109 checks passed
@mitruska mitruska deleted the mitruska/rms_op_shell branch April 15, 2024 09:20
alvoron pushed a commit to alvoron/openvino that referenced this pull request Apr 29, 2024
@mitruska @alvoron
[Op] Add RMSNorm op core class (openvinotoolkit#23842)
ddc44a2 
### Details:
 - RMSNorm op core class
- Registration in the opset and op check (conformance) test will be
added in the next PRs

Spec PR: 
- openvinotoolkit#23569

### Tickets:
 - 136261
@mitruska mitruska mentioned this pull request May 10, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praasz praasz praasz approved these changes

@mmikolajcz mmikolajcz mmikolajcz approved these changes

@PiotrKrzem PiotrKrzem Awaiting requested review from PiotrKrzem

Assignees

@mitruska mitruska

Labels
category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings category: CPU OpenVINO CPU plugin category: Opset OpenVINO Opset
Projects
None yet
Milestone
2024.2
Development

Successfully merging this pull request may close these issues.
3 participants
@mitruska @mmikolajcz @praasz