Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import ModuleExtension under try-except in OVC #23663

Merged
merged 5 commits into from
Mar 26, 2024
Merged

Import ModuleExtension under try-except in OVC #23663

merged 5 commits into from
Mar 26, 2024

Conversation

mvafin
Copy link
Contributor

@mvafin mvafin commented Mar 25, 2024

Details:

  • Import ModuleExtension under try-except

Tickets:

  • ticket-id

@mvafin mvafin requested a review from a team as a code owner March 25, 2024 17:01
@github-actions github-actions bot added the category: MO Model Optimizer label Mar 25, 2024
@rkazants rkazants requested a review from mryzhov March 25, 2024 18:14
@rkazants rkazants self-assigned this Mar 25, 2024
@rkazants
Copy link
Contributor

@mryzhov, does it solve a problem with tests in OV Tokenizers repo?

@mryzhov
Copy link
Contributor

mryzhov commented Mar 26, 2024

@mryzhov, does it solve a problem with tests in OV Tokenizers repo?
Yes, the problem has gone with this PR - openvinotoolkit/openvino_tokenizers#89

@slyalin slyalin self-requested a review March 26, 2024 14:49
slyalin
slyalin approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@slyalin slyalin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that it works with vLLM integration as before.

@mvafin mvafin enabled auto-merge March 26, 2024 19:18
@mvafin mvafin added this pull request to the merge queue Mar 26, 2024
Merged via the queue into openvinotoolkit:master with commit f57cd8c Mar 26, 2024
106 of 107 checks passed
@mvafin mvafin deleted the mvafin/pt_fe/module_ext_try branch March 26, 2024 21:20
bbielawx pushed a commit to bbielawx/openvino that referenced this pull request Apr 12, 2024
@mvafin @bbielawx
Import ModuleExtension under try-except in OVC (openvinotoolkit#23663)
3fb0b51 
### Details:
 - *Import ModuleExtension under try-except*

### Tickets:
 - *ticket-id*
alvoron pushed a commit to alvoron/openvino that referenced this pull request Apr 29, 2024
@mvafin @alvoron
Import ModuleExtension under try-except in OVC (openvinotoolkit#23663)
d0a8ec2 
### Details:
 - *Import ModuleExtension under try-except*

### Tickets:
 - *ticket-id*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slyalin slyalin slyalin approved these changes

@mryzhov mryzhov mryzhov approved these changes

@rkazants rkazants rkazants approved these changes

Assignees

@rkazants rkazants

Labels
category: MO Model Optimizer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mvafin @rkazants @mryzhov @slyalin