Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support aten::avg_poolNd and aten::max_poolNd with no batch #23586

Closed
wants to merge 3 commits into from
Closed

Conversation

krish1209
Copy link

@krish1209 krish1209 commented Mar 20, 2024

Two files updated and removed the new files I created.

#20927

@krish1209 krish1209 requested a review from a team as a code owner March 20, 2024 16:51
@github-actions github-actions bot added the category: PyTorch FE OpenVINO PyTorch Frontend label Mar 20, 2024
Copy link
Contributor

@mvafin mvafin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not create new files for these operations, rather update old files

}

// Call average pooling operation with extracted parameters
auto res = context.mark_node(std::make_shared<v8::AvgPool>(input, // Changed to AvgPool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how you reshape input to support CHW and NCHW cases.

@krish1209
Copy link
Author

Okay I'll update the old files and update the PR. Sorry for the inconvenience.

@andrei-kochin andrei-kochin changed the title New files for checking GFI#20927 Added support aten::avg_poolNd and aten::max_poolNd with no batch Mar 21, 2024
@mvafin
Copy link
Contributor

mvafin commented Mar 21, 2024

please also add tests for this functionality and verify that your code works

@krish1209
Copy link
Author

I am currently facing an "IncludePath" error even after adding the location of the header files so it is taking a little time to debug the same. onnx_pb.h is a file my system is unable to find. I'll get back as soon as possible after solving the error.

Also is it possible for you to guide me a little bit on how i can make a custom test case in the code base for these operations? It would be really helpful.

@krish1209
Copy link
Author

Hello Sir, I apologize for the absence. I got my head into a Research Paper based project for publishing, so couldn't find the time.
Is it possible for you to mention what all needs to be done in the markdown comment in order to merge this pull request in the main branch. Thank you. I will get at it as soon as possible :)

@krish1209 krish1209 requested a review from mvafin March 31, 2024 16:14
@krish1209
Copy link
Author

Can anyone provide an update so that I could be clarified the work I have to do. Thank you :)

@mvafin
Copy link
Contributor

mvafin commented Apr 8, 2024

Hello Sir, I apologize for the absence. I got my head into a Research Paper based project for publishing, so couldn't find the time. Is it possible for you to mention what all needs to be done in the markdown comment in order to merge this pull request in the main branch. Thank you. I will get at it as soon as possible :)

  • Write tests for pooling with no batch
  • Run your code and identify if all cases work
  • Fix issues and make sure that tests pass

@krish1209
Copy link
Author

Okay. Thank you for replying :). I will get on it as soon as possible.

Copy link
Contributor

github-actions bot commented May 3, 2024

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label May 3, 2024
@krish1209 krish1209 closed this by deleting the head repository May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: PyTorch FE OpenVINO PyTorch Frontend Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants