-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support aten::avg_poolNd and aten::max_poolNd with no batch #23586
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not create new files for these operations, rather update old files
} | ||
|
||
// Call average pooling operation with extracted parameters | ||
auto res = context.mark_node(std::make_shared<v8::AvgPool>(input, // Changed to AvgPool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see how you reshape input
to support CHW
and NCHW
cases.
Okay I'll update the old files and update the PR. Sorry for the inconvenience. |
please also add tests for this functionality and verify that your code works |
I am currently facing an "IncludePath" error even after adding the location of the header files so it is taking a little time to debug the same. onnx_pb.h is a file my system is unable to find. I'll get back as soon as possible after solving the error. Also is it possible for you to guide me a little bit on how i can make a custom test case in the code base for these operations? It would be really helpful. |
Hello Sir, I apologize for the absence. I got my head into a Research Paper based project for publishing, so couldn't find the time. |
Can anyone provide an update so that I could be clarified the work I have to do. Thank you :) |
|
Okay. Thank you for replying :). I will get on it as soon as possible. |
This PR will be closed in a week because of 2 weeks of no activity. |
Two files updated and removed the new files I created.
#20927