-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PT FE] Add aten::atan2 #23003
[PT FE] Add aten::atan2 #23003
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check that code builds before submitting
Hey @mvafin! I wrote this code for tffe this was a first draft will work on this |
Hi! @mvafin made some changes is this better? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also
fix build issues and code style
add different types for x and y
Hi! @mvafin @mmikolajcz I think i've fixed build issues and added test for different types in x and y. I had some questions: PS: the CI tests are failing with no error logs, |
Co-authored-by: Mateusz Mikolajczyk <mateusz.mikolajczyk@intel.com>
Hi @mvafin @mmikolajcz! Made the changes. Last time for the CI I guess the cmake did not configure properly. |
Hi @mvafin @mmikolajcz! Made the changes |
build_jenkins |
Tests fail with
|
Still same error:
|
This PR will be closed in a week because of 2 weeks of no activity. |
hey @rghvsh will you find a time to address Maxim's requests? |
This PR will be closed in a week because of 2 weeks of no activity. |
This PR was closed because it has been stalled for 2 week with no activity. |
Details:
Tickets: