Handle Reshape's special zero in SimplifySecondInputOfReshape #20785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimplifySecondInputOfReshape detects ShapeOf->Gather->Concat subgraphs on Reshape's second input and replaces ShapeOf->Gather with a Constant with zero(s). Currently it works only with Reshapes that have special_zero set to true, but it can work for Reshapes with special_zero == false if non-Gather inputs to Concat are Constants and don't contain any zero. Ticket: CVS-123434
github-actions
bot
added
the
category: transformations
itikhono
approved these changes
Nov 1, 2023
slyalin
reviewed
Nov 1, 2023
| } | ||
| comparator.enable(FunctionsComparator::ATTRIBUTES); | ||
| comparator.enable(FunctionsComparator::CONST_VALUES); | ||
| } |
There was a problem hiding this comment.
Can we use existing test and specialize them with special_zero=false? What's so special for these two cases?
There was a problem hiding this comment.
I believe we can improve this point in the next PR
slyalin
approved these changes
Nov 1, 2023
andrei-kochin
pushed a commit
that referenced
this pull request
Nov 2, 2023
#20820) * Handle Reshape's special zero in SimplifySecondInputOfReshape SimplifySecondInputOfReshape detects ShapeOf->Gather->Concat subgraphs on Reshape's second input and replaces ShapeOf->Gather with a Constant with zero(s). Currently it works only with Reshapes that have special_zero set to true, but it can work for Reshapes with special_zero == false if non-Gather inputs to Concat are Constants and don't contain any zero. Ticket: CVS-123434 * fix no default output Co-authored-by: Mateusz Tabaka <mateusz.tabaka@intel.com>
alvoron
pushed a commit
to alvoron/openvino
that referenced
this pull request
Nov 6, 2023
…notoolkit#20785) * Handle Reshape's special zero in SimplifySecondInputOfReshape SimplifySecondInputOfReshape detects ShapeOf->Gather->Concat subgraphs on Reshape's second input and replaces ShapeOf->Gather with a Constant with zero(s). Currently it works only with Reshapes that have special_zero set to true, but it can work for Reshapes with special_zero == false if non-Gather inputs to Concat are Constants and don't contain any zero. Ticket: CVS-123434 * fix no default output
allnes
pushed a commit
to allnes/openvino
that referenced
this pull request
Nov 23, 2023
…notoolkit#20785) * Handle Reshape's special zero in SimplifySecondInputOfReshape SimplifySecondInputOfReshape detects ShapeOf->Gather->Concat subgraphs on Reshape's second input and replaces ShapeOf->Gather with a Constant with zero(s). Currently it works only with Reshapes that have special_zero set to true, but it can work for Reshapes with special_zero == false if non-Gather inputs to Concat are Constants and don't contain any zero. Ticket: CVS-123434 * fix no default output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SimplifySecondInputOfReshape detects ShapeOf->Gather->Concat subgraphs on Reshape's second input and replaces ShapeOf->Gather with a Constant with zero(s). Currently it works only with Reshapes that have special_zero set to true, but it can work for Reshapes with
special_zero == falseif non-Gather inputs to Concat are Constants and don't contain any zero.Now for
special_zero == falsecase, the transformation checks that all inputs Constants to Concat don't contain 0 values and setsspecial_zero = trueflag to Reshape operation.Ticket: CVS-123434