Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ovc] check if input is correct in split_inputs #19350

Merged
merged 1 commit into from
Aug 30, 2023
Merged

[ovc] check if input is correct in split_inputs #19350

merged 1 commit into from
Aug 30, 2023

Conversation

pavel-esir
Copy link
Contributor

@pavel-esir pavel-esir commented Aug 22, 2023 •
edited
Loading

Details:

  • inputs with incorrect values were taken as is and then passed into PartialShape which caused ungraceful error message. Need to check if --input is acceptable before calling PartialShape.
  • Example of error message after fix

image

Tickets:

@pavel-esir pavel-esir added the bug Something isn't working label Aug 22, 2023
@pavel-esir pavel-esir added this to the 2023.2 milestone Aug 22, 2023
@pavel-esir pavel-esir requested a review from a team as a code owner August 22, 2023 20:56
@github-actions github-actions bot added category: MO Model Optimizer category: tools OpenVINO C++ / Python tools labels Aug 22, 2023
@pavel-esir pavel-esir modified the milestones: 2023.2, 2023.1 Aug 25, 2023
@pavel-esir pavel-esir mentioned this pull request Aug 25, 2023
Merged
@andrei-kochin andrei-kochin modified the milestones: 2023.1, 2023.2 Aug 28, 2023
@rkazants rkazants merged commit 9a1726a into openvinotoolkit:master Aug 30, 2023
22 checks passed
@pavel-esir pavel-esir deleted the correct_cli_parser branch August 30, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkazants rkazants rkazants approved these changes

Assignees
No one assigned
Labels
bug Something isn't working category: MO Model Optimizer category: tools OpenVINO C++ / Python tools
Projects
None yet
Milestone
2023.2
Development

Successfully merging this pull request may close these issues.
3 participants
@pavel-esir @rkazants @andrei-kochin