Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Torchscript backend #17132

Merged
merged 22 commits into from
May 17, 2023
Merged

Torchscript backend #17132

merged 22 commits into from
May 17, 2023

Conversation

suryasidd
Copy link
Contributor

@suryasidd suryasidd commented Apr 22, 2023 •
edited
Loading

Details:

  • Added torchscript backend to OpenVINO
  • Added an environment variable to enable torchscript backend USE_TS_BACKEND

Tickets:

  • ticket-id

@suryasidd
Added torch script backend
59b8df1
@suryasidd
Added ts_backend to pytorch layer tests
dc8f095 
* Added use_ts_backend fixture to the test suite to activate the
torchscript backend
@suryasidd
Merge branch 'master' into torchscript_backend
174c529
@github-actions github-actions bot added category: Python API OpenVINO Python bindings category: PyTorch FE OpenVINO PyTorch Frontend labels Apr 22, 2023
@mvafin
Copy link
Contributor

mvafin commented Apr 24, 2023 •
edited
Loading

Also it doesn't look like you added to precommit any of the tests. I don't think we need all of them in precommit, but several tests would be good to add.

@ilya-lavrenov ilya-lavrenov requested a review from eaidova April 24, 2023 21:19
@suryasidd
Copy link
Contributor Author

Also it doesn't look like you added to precommit any of the tests. I don't think we need all of them in precommit, but several tests would be good to add.

Added a few tests to precommit_ts_backend

@slyalin
Copy link
Contributor

slyalin commented May 2, 2023

@ynimmaga, @suryasidd, we need to move forward quickly. If we really want to merge before the release, then please remove Draft mark, retarget to the release branch and address the remaining issues and prepare a message for the committee to be able to merge to the release branch.

@github-actions github-actions bot added the category: CI OpenVINO public CI label May 2, 2023
@suryasidd suryasidd marked this pull request as ready for review May 2, 2023 22:30
@suryasidd suryasidd requested review from a team as code owners May 2, 2023 22:30
@suryasidd suryasidd requested a review from a team as a code owner May 2, 2023 22:30
@mvafin mvafin enabled auto-merge (squash) May 15, 2023 15:11
@mvafin
Copy link
Contributor

mvafin commented May 17, 2023

build_jenkins

@mvafin mvafin merged commit e14d1b2 into openvinotoolkit:master May 17, 2023
@ynimmaga ynimmaga deleted the torchscript_backend branch April 23, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ynimmaga ynimmaga ynimmaga left review comments

@slyalin slyalin slyalin approved these changes

@mvafin mvafin mvafin approved these changes

@eaidova eaidova Awaiting requested review from eaidova

Assignees
No one assigned
Labels
category: CI OpenVINO public CI category: Python API OpenVINO Python bindings category: PyTorch FE OpenVINO PyTorch Frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suryasidd @mvafin @slyalin @ynimmaga