【PaddlePaddle Hackathon 3】Add Paddle tile operator #12277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/core/tests/frontend/paddle/test_models/gen_scripts/generate_tile.py
Outdated
Show resolved
Hide resolved
ceciliapeng2011
requested changes
Jul 28, 2022
ceciliapeng2011
requested changes
Aug 7, 2022
| x = np.array([1, 2, 1]).astype("float32") | ||
| repeat_times = np.array([2, 1]).astype("int32") | ||
| paddle_tile("tile_tensor_list", x, repeat_times, tensor_list=True) | ||
| paddle_tile("tile_repeat_times_tensor", x, repeat_times, to_tensor=True) |
There was a problem hiding this comment.
The input X could be of more than 1 dimensions. And there could be cases like "Example 2: number of elements in “repeats” is more than shape of “data”" referring to https://docs.openvino.ai/latest/openvino_docs_ops_movement_Tile_1.html.
Could you please use a higher dimension (like 2 or 3 which is prone to have problems) instead of 1 and cover the case I mentioned?
There was a problem hiding this comment.
Thanks for contribution. Nice PR and close to be qualified.
There was a problem hiding this comment.
I have added unit tests for dimension inconsistency.
thanks for your review
AndPuQing
requested review from
ceciliapeng2011
and removed request for
openvino-dev-samples
|
Are there any other issues with this PR? |
ilyachur
approved these changes
Sep 1, 2022
ilya-lavrenov
added
ExternalPR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Reference
uni-test passed
