Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top k v2 #11731

Merged
merged 13 commits into from
Jun 15, 2022
Merged

Top k v2 #11731

merged 13 commits into from
Jun 15, 2022

Conversation

openvino-dev-samples
Copy link
Contributor

@openvino-dev-samples openvino-dev-samples commented May 23, 2022

Details:

  • add Top_k_v2 operation in Paddle front end

Tickets:

Reference:
https://www.paddlepaddle.org.cn/documentation/docs/zh/api/paddle/topk_cn.html#topk

Uni-test passed
Screenshot from 2022-05-23 23-32-36

@openvino-dev-samples openvino-dev-samples requested a review from a team as a code owner May 23, 2022 15:33
@yuxu42
Copy link
Contributor

yuxu42 commented Jun 2, 2022

@ceciliapeng2011 could you take a look at the CI failure, which need to re-trigger?

@yuxu42
Copy link
Contributor

yuxu42 commented Jun 7, 2022

@OpenVINO-dev-contest could you please take a look? There is CI failure.

@meiyang-intel
Copy link
Contributor

meiyang-intel commented Jun 8, 2022

Got error if 'k' is variable.
Fail to convert top_k_v2 Exception Check 'k_shape.rank().compatible(0)' failed at core/shape_inference/include/topk_shape_inference.hpp:33: While validating node 'v1::TopK TopK_7 (x[0]:f32{8,9,10}, Convert_6[0]:i32{1}) -> (dynamic...)' with friendly_name 'TopK_7': The 'K' input must be a scalar.

Have submitted a fix. Please review and merge. openvino-dev-samples#65

fix variable support issue for paddle top_k_v2
@yuxu42
Copy link
Contributor

yuxu42 commented Jun 11, 2022

@OpenVINO-dev-contest Could you please re-trigger the CI? Thanks!

@openvino-dev-samples
Copy link
Contributor Author

@OpenVINO-dev-contest Could you please re-trigger the CI? Thanks!

Done, seems some random failure happened again

Copy link
Contributor

@liubo-intel liubo-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @OpenVINO-dev-contest : requested by Xu Yu, I'm help have a look at the CI issue of this pr. well, also leave some comments(e.g. better use the default value for 'get_attribute()' function in case it throw error for models which doesn't set this attributes), please have a look at it when you are free, thx:)

openvino-dev-samples and others added 3 commits June 13, 2022 23:11
Co-authored-by: Bo Liu <bo4.liu@intel.com>
Co-authored-by: Bo Liu <bo4.liu@intel.com>
Co-authored-by: Bo Liu <bo4.liu@intel.com>
@openvino-dev-samples openvino-dev-samples requested a review from a team June 14, 2022 01:32
@openvino-dev-samples openvino-dev-samples requested review from a team as code owners June 14, 2022 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: PDPD FE OpenVINO PaddlePaddle FrontEnd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants