[Good First Issue]: Add test for CoreImpl::get_versions()

[vurusovs]

Context

After #22667 method CoreImpl::get_versions() has new logic based on string parsing:

if (exception.find("not registered in the OpenVINO Runtime")...

Need to add test to cover such case in order to prevent any unexpected changes

What needs to be done?

Test for

openvino/src/inference/src/dev/core_impl.cpp

Lines 1630 to 1632 in 3bdd728

	if (exception.find("not registered in the OpenVINO Runtime") == std::string::npos) {
	throw;
	}

to be added in src\inference\tests\functional\ov_register_plugin_test.cpp

Example Pull Requests

No response

Resources

• Contribution guide - start here!
• Intel DevHub Discord channel - engage in discussions, ask questions and talk to OpenVINO developers

Contact points

@vurusovs @olpipi

Ticket

CVS-132140

[awayzjj]

.take

[github-actions]

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

[awayzjj]

@vurusovs @olpipi Hi, I found there is already a test case below that should cover these three lines. The call stack is as follows:

openvino/src/inference/tests/functional/ov_register_plugin_test.cpp

Line 77 in 4f8f573

ASSERT_NO_THROW(core.get_versions("MOCK_HARDWARE"));

openvino/src/inference/src/dev/core_impl.cpp

Line 1626 in 4f8f573

ov::Plugin plugin = get_plugin(deviceNameLocal);

openvino/src/inference/src/dev/core_impl.cpp

Line 582 in 4f8f573

so = ov::util::load_shared_object(desc.libraryLocation.c_str());

openvino/src/common/util/src/os/lin/lin_shared_object_loader.cpp

Line 33 in 4f8f573

throw std::runtime_error(ss.str());

This test case is designed to raise an exception from lin_shared_object_loader.cpp, but the type of exception thrown is std::runtime_error. As a result, it cannot be caught by ov::Exception as seen in the following code:

openvino/src/inference/src/dev/core_impl.cpp

Lines 1628 to 1633 in 4f8f573

	} catch (const ov::Exception& ex) {
	std::string exception(ex.what());
	if (exception.find("not registered in the OpenVINO Runtime") == std::string::npos) {
	throw;
	}
	}

However, it is caught by the macro OV_CORE_CALL_STATEMENT used in the following code:

openvino/src/inference/src/cpp/core.cpp

Lines 80 to 82 in 4f8f573

	std::map<std::string, Version> Core::get_versions(const std::string& device_name) const {
	OV_CORE_CALL_STATEMENT({ return _impl->get_versions(device_name); })
	}

openvino/src/inference/src/cpp/core.cpp

Lines 54 to 61 in 4f8f573

	#define OV_CORE_CALL_STATEMENT(...) \
	try { \
	__VA_ARGS__; \
	} catch (const std::exception& ex) { \
	OPENVINO_THROW(ex.what()); \
	} catch (...) { \
	OPENVINO_THROW("Unexpected exception"); \
	}

I am wondering if I can replace } catch (const ov::Exception& ex) { with } catch (const std::runtime_error& ex) { in the 1628 line of core_impl.cpp, so the exception won't be caught in core.cpp

I tested this locally on my PC, and the log output indicates that the exception is indeed of type std::runtime_error and the 3 lines is covered by the test case. The attached screenshots show the details.

Besides, I'm wondering if there's a build option that allows me to use gdb with the source code for debugging from unit test file to openvino core src in this case. I tried `-DCMAKE_BUILD_TYPE=RelWithDebInfo` , but it isn't working.

[vurusovs]

@awayzjj hello!
All you described is right and correct - the purpose of

openvino/src/inference/src/dev/core_impl.cpp

Lines 1630 to 1632 in 3bdd728

	if (exception.find("not registered in the OpenVINO Runtime") == std::string::npos) {
	throw;
	}

is only to handle ov::Exception with not registered message and only for this case not throw but return empty object

So, the goal is to add new test case and call get_versions(...) with not registered plugin name (e.g. get_versions("NOT_REGISTERED_DEVICE")) and check that it doesn't throw and return empty object

[awayzjj]

@vurusovs Thank you for your reply! I have found a test case for an unregistered plugin name, which checks that no exception are thrown. Is there still a need for me to add a new test case, or is the existing one sufficient?

openvino/src/inference/tests/functional/ov_register_plugin_test.cpp

Lines 53 to 55 in 4f8f573

	TEST(RegisterPluginTests, getVersionforNoRegisteredPluginNoThrows) {
	ov::Core core;
	ASSERT_NO_THROW(core.get_versions("unkown_device"));

[vurusovs]

@awayzjj yes, it's actually what we needed, but I missed that it's already implemented. Anyway, could you extend the test with check that get_versions(...) return empty value?

[awayzjj]

@vurusovs Thank you for your reply! I extended the test with check that get_versions(...) return empty value. Could you please review the PR?