Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Good First Issue]: Extend ONNX Frontend with Function Mish-18 #20550

Closed
gkrivor opened this issue Oct 18, 2023 · 15 comments · Fixed by #22833
Closed

[Good First Issue]: Extend ONNX Frontend with Function Mish-18 #20550

gkrivor opened this issue Oct 18, 2023 · 15 comments · Fixed by #22833
Assignees
Labels
category: ONNX FE OpenVINO ONNX FrontEnd good first issue Good for newcomers no_stale Do not mark as stale
Milestone

Comments

@gkrivor
Copy link
Contributor

gkrivor commented Oct 18, 2023

Context

Neural networks are graphs consisting of nodes called operators. Each operator corresponds to a mathematical function, usually described in framework's documentation or an AI standard, such as ONNX.
OpenVINO ONNX Frontend is a component responsible for working with ONNX graphs and requires implementation of different ONNX operators in order to use ONNX models.
This task requires extending OpenVINO ONNX Frontend with Function Mish.
Necessary help will be provided by ONNX Fronted team.

What needs to be done?

Operator details can be found in ONNX Operators
More details can be found in ONNX Changelog

  1. Create .hpp and .cpp files here
  2. Prepare an implementation of this operator in form of a function. Mish-18 should be placed in opset 1 namespace.
  3. Register the function in ops_bridge.cpp while keeping alphabetical order
  4. Create test model(s) in ONNX models directory. OpenVINO test infrastructure then converts prototxt files to ONNX models - you will use those models later in tests
  5. Add tests covering all use cases here
  6. Check Python xfailed tests to find a test marked as a xfailed for added functionality. If any exist - remove corresponding lines and try to verify by using cmdline "python -m pytest -k name_of_test".
    More details in adding operators to ONNX Frontend guide

Example Pull Requests

Resources

Contact points

@gkrivor

Ticket

No response

@gkrivor gkrivor added good first issue Good for newcomers category: ONNX FE OpenVINO ONNX FrontEnd no_stale Do not mark as stale labels Oct 18, 2023
@urbalke
Copy link

urbalke commented Oct 30, 2023

Hello, why do You have *Windows in 1st ToDo? Is this platform specific?

@ilya-lavrenov
Copy link
Contributor

Hello, why do You have *Windows in 1st ToDo? Is this platform specific?

No, OpenVINO is cross platform product and steps are the same for all the systems.
Corrected description.

@sydarb
Copy link
Contributor

sydarb commented Dec 9, 2023

Hey @p-wysocki I would like to work on this.

@p-wysocki
Copy link
Contributor

Hello @sydarb, are you still working on this? I see that the PR is nearly finished.

Also, I am happy to announce that we have created a channel dedicated to Good First Issues support on our Intel DevHub Discord server! Join it to receive support, engage in discussions, ask questions and talk to OpenVINO developers.

@kshitij01042002
Copy link

Hi @p-wysocki is this issue up for grab? Also I tried joining the discord channel via the link provided but it says invalid link, can you please double check? Thanks.

@p-wysocki
Copy link
Contributor

Hi @kshitij01042002, you can pick it up, thanks for taking a look!

The correct Discord link is https://discord.com/invite/7pVRxUwdWG, it has been corrected everywhere but in the issues created before we realized that the link is dead. Sorry for that! :)

@p-wysocki p-wysocki assigned kshitij01042002 and unassigned sydarb Feb 12, 2024
@PRATHAM-SPS
Copy link
Contributor

Hi @p-wysocki , it's nice to see you again! Could you please assign me this task? I'd like to do it.

@kshitij01042002
Copy link

kshitij01042002 commented Feb 14, 2024

Hi @p-wysocki I am currently working on #20562. You can assign this issue to @PRATHAM-SPS

@p-wysocki
Copy link
Contributor

Hello, I assigned the task to @PRATHAM-SPS. :)

@PRATHAM-SPS
Copy link
Contributor

Hello , please review the pull request I've created at the following link:-#22833. Your feedback would be greatly appreciated, @gkrivor and @p-wysocki.

@mitruska
Copy link
Contributor

Hello @PRATHAM-SPS, thank you for this contribution.
I've reviewed the mentioned PR #22833, please take a look at the comments there.

@mlukasze mlukasze added this to the 2024.1 milestone Feb 19, 2024
github-merge-queue bot pushed a commit that referenced this issue Feb 19, 2024
### Details:
- *Expand the ONNX Frontend Capabilities by Incorporating the Mish-18
Function*

### Tickets:
 - *Closes #20550*
@PRATHAM-SPS
Copy link
Contributor

Hello @p-wysocki, can I get more such operators to wotk on ??

@p-wysocki
Copy link
Contributor

Hi @PRATHAM-SPS, @mitruska mentioned she might have something for you. :) Let's wait for a response.

@mitruska
Copy link
Contributor

Hello @PRATHAM-SPS, let me answer:)
Of course you can! Great to see your willing to continue contributing to OpenVINO.

Feel free to take any ticket from the Good First Issue Board ("Contributors Needed" column).
If you are looking for a similar task, I can recommend to try the following:

@PRATHAM-SPS
Copy link
Contributor

PRATHAM-SPS commented Feb 21, 2024

Thankyou, @p-wysocki and @mitruska , I've taken responsibility for this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: ONNX FE OpenVINO ONNX FrontEnd good first issue Good for newcomers no_stale Do not mark as stale
Projects
Archived in project
9 participants