Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable pyupgrade and flake8-errmsg rules in ruff #3221

Merged
merged 19 commits into from
Jan 31, 2025
Merged

Enable pyupgrade and flake8-errmsg rules in ruff #3221

merged 19 commits into from
Jan 31, 2025

Conversation

AlexanderDokuchaev
Copy link
Collaborator

Changes

https://docs.astral.sh/ruff/rules/#pyupgrade-up
https://docs.astral.sh/ruff/rules/#flake8-errmsg-em

Rules regarding annotations will be enableв in next pr

    "UP006", # non-pep585-annotation
    "UP007", # non-pep604-annotation-union
    "UP035", # deprecated-import
    "UP038", # non-pep604-isinstance
    "UP045", # non-pep604-annotation-optional

@github-actions github-actions bot added NNCF TF Pull requests that updates NNCF TensorFlow NNCF PT Pull requests that updates NNCF PyTorch NNCF Common Pull request that updates NNCF Common experimental NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF ONNX Pull requests that updates NNCF ONNX NNCF PTQ Pull requests that updates NNCF PTQ labels Jan 29, 2025
@AlexanderDokuchaev AlexanderDokuchaev marked this pull request as ready for review January 29, 2025 10:34
@AlexanderDokuchaev AlexanderDokuchaev requested a review from a team as a code owner January 29, 2025 10:34
@KodiaqQ KodiaqQ self-requested a review January 30, 2025 16:08
@MaximProshin
Copy link
Collaborator

@AlexanderDokuchaev , please run nightly and SDL checks before the merge to make sure no new issues are introduced.

@AlexanderDokuchaev
Copy link
Collaborator Author

AlexanderDokuchaev commented Jan 31, 2025 •
edited
Loading

@MaximProshin
https://github.com/openvinotoolkit/nncf/actions/runs/13074112893
https://github.com/openvinotoolkit/nncf/actions/runs/13072236536
https://github.com/openvinotoolkit/nncf/actions/runs/13072240952
https://github.com/openvinotoolkit/nncf/actions/runs/13072245707
manual/job/post_training_quantization/587/
nightly/job/sdl/job/nightly_trigger/425/

  • checkmarx falls on
-    logger.info("Save directory: {}".format(config.log_dir))
+    logger.info(f"Save directory: {config.log_dir}")

That was marked as "Not Exploitable".
@KodiaqQ please update checkmarx state for this issue after merge, i have no permission

@KodiaqQ KodiaqQ merged commit f21215b into openvinotoolkit:develop Jan 31, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniil-lyakhov daniil-lyakhov daniil-lyakhov approved these changes

@kshpv kshpv kshpv approved these changes

@ljaljushkin ljaljushkin ljaljushkin approved these changes

@alexsu52 alexsu52 alexsu52 approved these changes

@KodiaqQ KodiaqQ Awaiting requested review from KodiaqQ

Assignees

@KodiaqQ KodiaqQ

Labels
experimental NNCF Common Pull request that updates NNCF Common NNCF ONNX Pull requests that updates NNCF ONNX NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF PT Pull requests that updates NNCF PyTorch NNCF PTQ Pull requests that updates NNCF PTQ NNCF TF Pull requests that updates NNCF TensorFlow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@AlexanderDokuchaev @MaximProshin @alexsu52 @ljaljushkin @kshpv @KodiaqQ @daniil-lyakhov