Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest optimum to not call deprecated shared_memory API #2569

Merged

Conversation

ljaljushkin
Copy link
Contributor

@ljaljushkin ljaljushkin commented Mar 11, 2024

Changes

use the latest release of optimum-intel==1.15.2

Reason for changes

The previously used version of optimum had a call of deprecated API that was removed in 2024 release of OpenVINO.
openvinotoolkit/openvino#21979

outputs = self.request(inputs, shared_memory=True)

Latest optimum migrated to the actual API.

Related tickets

n/a

Tests

  • weight compression conformance (local run)
  • weight compression conformance (CI build 32)
  • ptq conformance build (CI build 331)
  • single test job for failing GPTCausal model 6314

@ljaljushkin ljaljushkin requested a review from a team as a code owner March 11, 2024 10:03
@github-actions github-actions bot added the NNCF PTQ Pull requests that updates NNCF PTQ label Mar 11, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.83%. Comparing base (12f4720) to head (52dbd42).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2569      +/-   ##
===========================================
- Coverage    91.18%   84.83%   -6.36%     
===========================================
  Files          492      492              
  Lines        45096    45100       +4     
===========================================
- Hits         41123    38261    -2862     
- Misses        3973     6839    +2866     

see 56 files with indirect coverage changes

Flag Coverage Δ
COMMON 43.92% <ø> (-0.01%) ⬇️
ONNX 34.66% <ø> (-0.01%) ⬇️
OPENVINO ∅ <ø> (∅)
TENSORFLOW 29.87% <ø> (-0.01%) ⬇️
TORCH 65.76% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
common 93.11% <ø> (-0.66%) ⬇️
torch 93.59% <ø> (ø)
tensorflow 93.74% <ø> (ø)
onnx 93.05% <ø> (ø)
openvino 25.58% <ø> (-68.49%) ⬇️
ptq 69.78% <ø> (-20.45%) ⬇️

@ljaljushkin
Copy link
Contributor Author

run tensorflow pre-commit tests

@ljaljushkin
Copy link
Contributor Author

PTQ test crashes with segfault, reproduced locally. Please don't merge until resolving the issue
@KodiaqQ

@ljaljushkin
Copy link
Contributor Author

gfault, reproduced locally. Please don't merge until resolving

Created a bug 135375 for CPU plugin

@KodiaqQ
Copy link
Collaborator

KodiaqQ commented Mar 18, 2024

@ljaljushkin, the bug is still actual and needs to be fixed.
What will we do with the segfault?

@ljaljushkin
Copy link
Contributor Author

@ljaljushkin, the bug is still actual and needs to be fixed. What will we do with the segfault?

This is the bug for CPU plugin, therefore we will wait for the fix.

@KodiaqQ
Copy link
Collaborator

KodiaqQ commented Mar 18, 2024

This is the bug for CPU plugin, therefore we will wait for the fix.

We will wait till the next OpenVINO release (or even another one) until then the weekly runs will be red. Am I right?

@ljaljushkin
Copy link
Contributor Author

e the latest release of optimum-intel==1.15.

No, originally you asked not correct question.
Weekly tests are failing not because of segfault, they fail because test depend on the old optimum which uses a removed API.
Segfault coming from using latest openvino and optimum version. I will think about another approach for fixing weekly test to avoid bug with segfault, while runtime team is working on fixing it.

@KodiaqQ
Copy link
Collaborator

KodiaqQ commented Mar 18, 2024

No, originally you asked not correct question. Weekly tests are failing not because of segfault, they fail because test depend on the old optimum which uses a removed API. Segfault coming from using latest openvino and optimum version. I will think about another approach for fixing weekly test to avoid bug with segfault, while runtime team is working on fixing it.

I push this because the weekly tests are red for a few weeks and there is no estimation to merge this PR due to segfault.
And there is even no activity with the segfault itself.
Red weekly tests affect the upcoming NNCF release as well. It's highly recommended to fix it before the release branch creation.

@alexsu52
Copy link
Contributor

No, originally you asked not correct question. Weekly tests are failing not because of segfault, they fail because test depend on the old optimum which uses a removed API. Segfault coming from using latest openvino and optimum version. I will think about another approach for fixing weekly test to avoid bug with segfault, while runtime team is working on fixing it.

I push this because the weekly tests are red for a few weeks and there is no estimation to merge this PR due to segfault. And there is even no activity with the segfault itself. Red weekly tests affect the upcoming NNCF release as well. It's highly recommended to fix it before the release branch creation.

As workaround you can use stateless model instead of stateful.

@github-actions github-actions bot added the NNCF OpenVINO Pull requests that updates NNCF OpenVINO label Mar 20, 2024
@github-actions github-actions bot removed the NNCF OpenVINO Pull requests that updates NNCF OpenVINO label Mar 20, 2024
also WA with stateless to avoid segfault
@ljaljushkin
Copy link
Contributor Author

Here's the fix for segfault.
openvinotoolkit/openvino#23581

@KodiaqQ KodiaqQ merged commit 7974023 into openvinotoolkit:develop Mar 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NNCF PTQ Pull requests that updates NNCF PTQ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants