Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Add workaround fix when batch size > 1 for MaskRCNN #70

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

eugene123tw
Copy link
Contributor

@eugene123tw eugene123tw commented Oct 19, 2022

index out of range bug in instance seg after introducing batch size > 1 in this PR. For some reason, scale_factors in simple_test_mask is hardcoded and strictly has only one item in the list , I'm guessing it's related to OpenVINO export and need some time to investigate

@eugene123tw eugene123tw changed the title Add workaround of batch size > 1 for MaskRCNN Add workaround when batch size > 1 for MaskRCNN Oct 19, 2022
@eugene123tw eugene123tw changed the title Add workaround when batch size > 1 for MaskRCNN Add workaround fix when batch size > 1 for MaskRCNN Oct 19, 2022
@harimkang harimkang requested a review from sungmanc October 19, 2022 23:59
@sungmanc
Copy link
Contributor

@harimkang @eugene123tw , how about merging this PR as a quick solution? As Eugene said, we need some time to investigate for the instance segmentation.

@harimkang
Copy link
Contributor

@harimkang @eugene123tw , how about merging this PR as a quick solution? As Eugene said, we need some time to investigate for the instance segmentation.

Yes, first of all, I agree.

@sungmanc sungmanc merged commit d960005 into develop Oct 20, 2022
@sungmanc sungmanc deleted the eugene/CVS-94422-size-bug branch October 20, 2022 01:45
goodsong81 added a commit that referenced this pull request Dec 28, 2022
* fixed multilabel configs (#67)

* Tiling Module (#40)

* Feature/val batch and seed (#69)

* workaround bug (#70)

* Kp/devide runners (#71)

* move ema model to hook (#73)

* Appley release/OTE_0.3.0 changes (#77)

* Per-group softmax output (#74)

* Move drop_last in cls trainer.py (#79)

* Removed unnecessary mim version constraint for networkx package (#80)

* Revert "Removed unnecessary mim version constraint for networkx package (#80)" (#82)

* Don't apply activations on export in classification (#83)

* Delete unused code (#84)

* Replace current saliency map generation with Recipro-CAM for cls (#81)

* Class-wise saliency map generation for the detection task (#97)

* [XAI] hot-fix of error in Detection XAI support (#98)

* [XAI] hot-fix of error in Detection XAI support (#99)

* Replace only the first occurrence in the state_dict keys (#91)

* [OTE / XAI] Handle two stage detector in the inferrer.py (#104)

* [XAI] hot-fix of error in Detection XAI support (#98)

* [OTE / XAI][Develop] Handle two stage detector in the inferrer.py (#107)

* [XAI] hot-fix of error in Detection XAI support (#99)

* Merge OTE side XAI update to OTX (#109)

* Merge back releases/OTE_0.4.0 to develop (#116)

* [XAI] hot-fix of error in Detection XAI support (#99)

* [OTE / XAI] Handle two stage detector in the inferrer.py (#104)

* [XAI] hot-fix of error in Detection XAI support (#98)

* [Hot-fix] Fix zero-division error in one cycle lr scheduler in multilabel classification

* Fix extra activations when exporting nonlinear hierarchical head (#118)

* Fix get_train_data_cfg -> get_data_cfg

Signed-off-by: Songki Choi <songki.choi@intel.com>
Co-authored-by: Prokofiev Kirill <kirill.prokofiev@intel.com>
Co-authored-by: Eugene Liu <eugene.liu@intel.com>
Co-authored-by: Sungman Cho <sungman.cho@intel.com>
Co-authored-by: Jihwan Eom <jihwan.eom@intel.com>
Co-authored-by: Yunchu Lee <yunchu.lee@intel.com>
Co-authored-by: Vladislav Sovrasov <vladislav.sovrasov@intel.com>
Co-authored-by: Evgeny Tsykunov <e.tsykunov@gmail.com>
Co-authored-by: dongkwan-kim <dongkwan.kim@intel.com>
Co-authored-by: Adria Arrufat <adria.arrufat@intel.com>
Co-authored-by: Soobee Lee <soobee.lee@intel.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants