Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Attrs Classes and Fields #65

Merged
merged 2 commits into from
Oct 12, 2022
Merged

Updated Attrs Classes and Fields #65

merged 2 commits into from
Oct 12, 2022

Conversation

HiteshManglani123
Copy link
Contributor

Previously we were using the legacy attrs API where classes were decorated with attr.s() and fields were decorated with attr.ib(). Now the classes and fields are decorated with define()' and field()`.

@HiteshManglani123 HiteshManglani123 self-assigned this Oct 11, 2022
ljcornel
ljcornel reviewed Oct 11, 2022
View reviewed changes
Copy link
Collaborator

@ljcornel ljcornel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Hitesh, the PR looks good but I do have some questions related to slotted vs non-slotted classes, see my comments in the code

geti_sdk/data_models/algorithms.py Outdated Show resolved Hide resolved
geti_sdk/data_models/configuration.py Outdated Show resolved Hide resolved
geti_sdk/data_models/configuration.py Outdated Show resolved Hide resolved
geti_sdk/data_models/shapes.py Outdated Show resolved Hide resolved
geti_sdk/data_models/shapes.py Outdated Show resolved Hide resolved
@HiteshManglani123 HiteshManglani123 merged commit 5504e26 into main Oct 12, 2022
@HiteshManglani123 HiteshManglani123 deleted the hitesh/CVS-85322/update-attrs-version branch October 12, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljcornel ljcornel ljcornel approved these changes

Assignees

@HiteshManglani123 HiteshManglani123

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HiteshManglani123 @ljcornel