Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDK platform version parsing mechanism #58

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

ljcornel
Copy link
Collaborator

@ljcornel ljcornel commented Oct 6, 2022

  • Remove the dependency on version.parse, which can return a deprecated LegacyVersion object in case the version pattern does not match
  • Parse full build version returned by the platform and use that to perform version comparisons

@ljcornel ljcornel merged commit 5669069 into main Oct 6, 2022
@ljcornel ljcornel deleted the remove_LegacyVersion_parsing branch October 6, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant