Introduce new Anomaly task
#487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atwinand
reviewed
Sep 9, 2024
igor-davidyuk
commented
Sep 9, 2024
igor-davidyuk
force-pushed
the
idavidyu/introduce-common-anomaly-task
branch
2 times, most recently
from
df11442 to
86c9a57
Compare
ljcornel
reviewed
Sep 12, 2024
| @@ -160,6 +161,18 @@ def get_data( | |||
| label_name=label_dict["name"] | |||
| ) | |||
| new_annotations.append(annotation_object) | |||
| if "anomal" in annotation_object.labels[0].name.lower(): | |||
There was a problem hiding this comment.
Why don't you just check annotation_object.labels[0].name.lower() == "anomalous"? I believe that has been a constant throughout all older versions of Geti, the name of the anomalous label has not changed.
There was a problem hiding this comment.
We should not rely on the label name. Unfortunately, we do not save the 'is_anomalous' label flag.
igor-davidyuk
commented
Sep 12, 2024
igor-davidyuk
commented
Sep 12, 2024
igor-davidyuk
force-pushed
the
idavidyu/introduce-common-anomaly-task
branch
from
3531616 to
9af57a9
Compare
igor-davidyuk
force-pushed
the
idavidyu/introduce-common-anomaly-task
branch
from
9af57a9 to
5b43205
Compare
ljcornel
approved these changes
Sep 24, 2024
igor-davidyuk
force-pushed
the
idavidyu/introduce-common-anomaly-task
branch
from
3c5df51 to
cfaedfd
Compare
Signed-off-by: Igor-Davidyuk <igor.davidyuk@intel.com>
Signed-off-by: Igor-Davidyuk <igor.davidyuk@intel.com>
Signed-off-by: Igor-Davidyuk <igor.davidyuk@intel.com>
Signed-off-by: Igor-Davidyuk <igor.davidyuk@intel.com>
Signed-off-by: Igor-Davidyuk <igor.davidyuk@intel.com>
Signed-off-by: Igor-Davidyuk <igor.davidyuk@intel.com>
Signed-off-by: Igor-Davidyuk <igor.davidyuk@intel.com>
Signed-off-by: Igor-Davidyuk <igor.davidyuk@intel.com>
Signed-off-by: Igor-Davidyuk <igor.davidyuk@intel.com>
Signed-off-by: Igor-Davidyuk <igor.davidyuk@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a part of the Platform Anomaly Reduction initiative.