Implement Platform version check #474
Conversation
igor-davidyuk
changed the title
igor-davidyuk
force-pushed
the
idavidyu/platform-version-check
branch
from
c353860 to
6f00cc6
Compare
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
| Intel® Geti™ SDK. | ||
| """ | ||
| # Get the build version without a timestamp | ||
| platform_version = self.session.version.version |
There was a problem hiding this comment.
Minor suggestion for another PR: repetitions like .version.version aren't a good software practice; the problem is the GetiVersion class which exposes a version attribute. I believe it would be better if that information was exposed through __str__, so that str(session.version) would return a string like "1.8.0". Methods like __eq__, __lt__, ... could be be smarter and support both strings and GetiVersion objects.
There was a problem hiding this comment.
For the __str__ method - what you suggested is what is already implemented in the code.
A GetiVersion takes into account both the release version and the timestamp, while it's version field only represents the numeric version.
May be we should rename it to base_version
SaaS users may experience silent platform updates, thus they need to be reminded to upgrade the SDK package.