Create workflow to build wheels for different OS/CPU architecture combinations #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -64,7 +64,7 @@ def get_requirements(filename: str) -> List[str]: | |||
| "License :: OSI Approved :: Apache Software License", | |||
| ], | |||
| packages=setuptools.find_packages(), | |||
| python_requires=">=3.9", | |||
| python_requires=">=3.9,<3.12", | |||
There was a problem hiding this comment.
Are you sure 3.12 works? Last time I tried there were no datumaro package for this version
There was a problem hiding this comment.
No, it's 'less than 3.12', so it doesn't include 3.12
igor-davidyuk
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, installing the geti-sdk on macOS, or on any machine with arm64 architecture will require building datumaro from source. This requires Rust to be installed, which not all of our users may have. This PR is a first step to address this by building wheels for these OS'es and architectures, using the
cibuildwheelslibrary. It is still experimental, most likely the configuration needs to be tweaked for it to work.Once building the wheels works, the next step would be to add a job that pulls the artifacts and publishes them to pypi.