Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Visualizer class #426

Merged
merged 9 commits into from
Jul 4, 2024
Merged

Expose Visualizer class #426

merged 9 commits into from
Jul 4, 2024

Conversation

igor-davidyuk
Copy link
Contributor

This PR introduces the Visualizer class to the user Python API to increase flexibility.

@igor-davidyuk igor-davidyuk force-pushed the idavidyu/visualizer-api branch 2 times, most recently from 33805f3 to 4c39aed Compare July 2, 2024 08:07
@igor-davidyuk igor-davidyuk marked this pull request as ready for review July 2, 2024 09:47
@igor-davidyuk igor-davidyuk force-pushed the idavidyu/visualizer-api branch from 4c39aed to bba386f Compare July 2, 2024 09:53
@igor-davidyuk igor-davidyuk requested a review from ljcornel July 2, 2024 09:53
Copy link
Collaborator

@ljcornel ljcornel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Few very minor comments, thanks for addressing this. The visualization API is much cleaner this way.

notebooks/003_upload_and_predict_image.ipynb Outdated Show resolved Hide resolved
notebooks/005_modify_image.ipynb Outdated Show resolved Hide resolved
notebooks/008_deploy_project.ipynb Show resolved Hide resolved
@igor-davidyuk igor-davidyuk force-pushed the idavidyu/visualizer-api branch from bba386f to ee28f9f Compare July 3, 2024 09:28
@igor-davidyuk igor-davidyuk requested a review from ljcornel July 3, 2024 10:09
@igor-davidyuk igor-davidyuk force-pushed the idavidyu/visualizer-api branch from 16b0399 to 29069cc Compare July 4, 2024 07:50
geti_sdk/deployment/resources/OVMS_README.md Outdated Show resolved Hide resolved
notebooks/008_deploy_project.ipynb Outdated Show resolved Hide resolved
notebooks/010_model_serving.ipynb Outdated Show resolved Hide resolved
notebooks/012_post_inference_hooks.ipynb Outdated Show resolved Hide resolved
igor-davidyuk and others added 9 commits July 4, 2024 12:52
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>

merge python version
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
Signed-off-by: Igor Davidyuk <igor.davidyuk@intel.com>
Changing the visualizer import path

Co-authored-by: Ludo Cornelissen <ludo.cornelissen@intel.com>
@igor-davidyuk igor-davidyuk force-pushed the idavidyu/visualizer-api branch from b9f4195 to 8cdfa1e Compare July 4, 2024 09:52
@igor-davidyuk igor-davidyuk merged commit 01832f5 into main Jul 4, 2024
11 checks passed
@igor-davidyuk igor-davidyuk deleted the idavidyu/visualizer-api branch July 4, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants